Fix the bindhandle tests to use the correct interop description for calling CreateFile#123685
Merged
davidwrighton merged 1 commit intodotnet:mainfrom Jan 28, 2026
Merged
Conversation
Member
davidwrighton
commented
Jan 27, 2026
- The Atts and Template parameters are actually pointers, and the existing prototypes were only passing 32bit integers
…alling CreateFile - The Atts and Template parameters are actually pointers, and the existing prototypes were only passing 32bit integers
Contributor
|
Tagging subscribers to this area: @agocke, @VSadov |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect P/Invoke declarations for the Windows CreateFile API in three bindhandle test files. The 4th and 7th parameters (security attributes and template file handle) are pointer types in the native API and must be declared as pointer-sized types in the managed signature.
Changes:
- Updated
CreateFileP/Invoke declarations to usenintinstead ofintfor pointer parameters - Ensures proper interop behavior on 64-bit systems where pointers are 64 bits
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/tests/baseservices/threading/threadpool/bindhandle/bindhandleinvalid6.cs |
Fixed CreateFile P/Invoke signature to use nint for Atts and Template parameters |
src/tests/baseservices/threading/threadpool/bindhandle/bindhandleinvalid3.cs |
Fixed CreateFile P/Invoke signature to use nint for Atts and Template parameters |
src/tests/baseservices/threading/threadpool/bindhandle/bindhandle1.cs |
Fixed CreateFile P/Invoke signature to use nint for Atts and Template parameters |
jkoritzinsky
approved these changes
Jan 27, 2026
Member
Author
|
/ba-g test failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.