SPMI: Fix aligned allocation size computation#123707
Merged
jakobbotsch merged 2 commits intodotnet:mainfrom Jan 28, 2026
Merged
SPMI: Fix aligned allocation size computation#123707jakobbotsch merged 2 commits intodotnet:mainfrom
jakobbotsch merged 2 commits intodotnet:mainfrom
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts SuperPMI’s allocMem allocation sizing so there is sufficient space after aligning the returned pointer, preventing under-allocation when an alignment bump occurs.
Changes:
- Allocate hot code buffers with extra padding before aligning the returned pointer.
- Allocate readonly data buffers with extra padding before aligning the returned pointer.
EgorBo
approved these changes
Jan 28, 2026
Member
Author
|
/ba-g SPMI only change fixing JIT pipelines |
This was referenced Jan 28, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rounding up the size is not enough (in the worst case the size is already aligned; that doesn't automatically mean the returned memory address will be aligned).