Override ResolveReadyToRunCompilers for TestReadyToRun=true test builds #123734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #123499 where runtime-coreclr crossgen2 TestReadyToRun_Libraries pipelines fail with error NETSDK1095 about ReadyToRun compilation not being supported for the selected target platform or architecture.
Changes:
- Creates a new
tests.readytorun.targetsfile that overrides the SDK'sResolveReadyToRunCompilerstarget to use the in-tree crossgen2 compiler instead of relying on SDK-provided crossgen2 packs - Integrates this new targets file into the test build process by importing it via
AfterMicrosoftNETSdkTargetswhenTestReadyToRunis enabled
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/testing/tests.singlefile.targets | Adds import of tests.readytorun.targets after SDK targets when TestReadyToRun is enabled |
| eng/testing/tests.readytorun.targets | New file that overrides ResolveReadyToRunCompilers target to point to in-tree crossgen2 compiler, with special handling for Android targets |
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 29, 2026
Open
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 30, 2026
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
commented
Jan 31, 2026
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…r to handle our live-ref-pack copies (and remove a prior hack that isn't needed any more).
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jakobbotsch
approved these changes
Feb 3, 2026
jtschuster
approved these changes
Feb 3, 2026
Member
Author
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123499