JIT: fix arm32 dump/disasm of references to async resume info#123814
Merged
jakobbotsch merged 4 commits intomainfrom Jan 31, 2026
Merged
JIT: fix arm32 dump/disasm of references to async resume info#123814jakobbotsch merged 4 commits intomainfrom
jakobbotsch merged 4 commits intomainfrom
Conversation
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix arm32 dump/disasm of async resume info references
JIT: fix arm32 dump/disasm of references to async resume info
Jan 30, 2026
jakobbotsch
reviewed
Jan 30, 2026
…s-table data Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
jakobbotsch
approved these changes
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an ARM32 JIT dump/disasm assertion failure that occurs when encountering async resume info references. The IF_T2_N2 instruction format is used for both block address tables (jump tables) and async resume info references, but the dump logic only expected block address tables.
Changes:
- Removes assertion that fails when
jdscis null (async resume info case) - Adds conditional logic to handle both block address tables and async resume info appropriately
- Updates NULL to nullptr for C++ style consistency
EgorBo
approved these changes
Jan 30, 2026
This was referenced Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ARM32 JIT dump/disasm asserts when encountering async resume info references. The
IF_T2_N2instruction format handles both block address tables and async resume info, but the dump logic only expected the former.Changes
emitarm.cpp:7308: Was failing whenjdscis null (async resume info case)jdscis nullnullptrinstead ofNULL: Modern C++ style throughout the code blockRWD%02zuformat for async resume info (whenjdscis null) andJ_M%03u_DS%02uformat for block address tables (whenjdscis not null)jdscis null vs non-nullThe fix preserves all existing dump behavior for block address tables while allowing async resume info to display properly without assertion.
Affects dump/disasm output only; no impact on code generation.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.