[Wasm RyuJit] fix local type encoding#124137
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Feb 8, 2026
Merged
Conversation
Member
Author
|
@dotnet/jit-contrib PTAL |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes WASM local type encoding in the CoreCLR JIT emitter by aligning the WasmValueType → WASM binary type-code lookup table order with the WasmValueType enum order.
Changes:
- Reordered
typecode_mappinginGetWasmValueTypeCodeto matchWasmValueTypeenum values. - Updated inline comments to reflect the corrected enum-to-index mapping.
This was referenced Feb 8, 2026
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
adamperlin
approved these changes
Feb 8, 2026
Contributor
adamperlin
left a comment
There was a problem hiding this comment.
This looks good to me, thank you for fixing this!
kg
approved these changes
Feb 8, 2026
Member
Author
|
Failure is unrelated, looks like a GC issue on arm32 Opened #124153 |
Member
Author
|
/ba-g unrelated gc issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order needs to match the enum order in
WasmValueType.