Skip to content

[ios] HelloiOS - Set RunAOTCompilation only on Mono#124265

Merged
davidnguyen-tech merged 2 commits intodotnet:mainfrom
davidnguyen-tech:docs/ios-coreclr-helloios-commands
Feb 19, 2026
Merged

[ios] HelloiOS - Set RunAOTCompilation only on Mono#124265
davidnguyen-tech merged 2 commits intodotnet:mainfrom
davidnguyen-tech:docs/ios-coreclr-helloios-commands

Conversation

@davidnguyen-tech
Copy link
Member

@davidnguyen-tech davidnguyen-tech commented Feb 11, 2026

Description

When we have /p:RunAOTCompilation=true and /p:UseMonoRuntime=false, dotnet publish fails with an ILStrip error because it routes the CoreCLR build through Mono's AOT-related targets that produce an empty assemblies list for ILStrip.

Because of that, we fix the HelloiOS sample to default to /p:RunAOTCompilation=true only on Mono.

Copilot AI review requested due to automatic review settings February 11, 2026 12:27
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the /p:RunAOTCompilation=false flag to the HelloiOS sample build and publish commands in the CoreCLR iOS documentation. The flag was inadvertently removed in PR #124230 but is necessary to prevent build failures when using CoreCLR on iOS.

Changes:

  • Added /p:RunAOTCompilation=false to the dotnet.sh build command for the HelloiOS sample
  • Added /p:RunAOTCompilation=false to the dotnet.sh publish command for the HelloiOS sample

@davidnguyen-tech davidnguyen-tech added documentation Documentation bug or enhancement, does not impact product or test code os-ios Apple iOS and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 11, 2026
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@davidnguyen-tech
Copy link
Member Author

/ba-g Markdown changes

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2026
@kotlarmilos
Copy link
Member

Thanks. I suggest to add condition to the sample project instead:

<RunAOTCompilation Condition="'$(RunAOTCompilation)' == '' and '$(UseMonoRuntime)' == 'true'">true</RunAOTCompilation>

@kotlarmilos kotlarmilos removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2026
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2026
@davidnguyen-tech davidnguyen-tech changed the title Add missing /p:RunAOTCompilation=false to HelloiOS CoreCLR doc commands [ios] HelloiOS - Set RunAOTCompilation only on Mono Feb 12, 2026
@davidnguyen-tech
Copy link
Member Author

/ba-g Markdown changes

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidnguyen-tech
Copy link
Member Author

/ba-g Irrelevant failures

@davidnguyen-tech davidnguyen-tech merged commit 2af34ab into dotnet:main Feb 19, 2026
104 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation bug or enhancement, does not impact product or test code needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-ios Apple iOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments