Skip to content

Configure markdownlint to allow 2-space hard line breaks#124275

Merged
MihaZupan merged 4 commits intomizupan/uri-threatmodelsfrom
copilot/add-markdownlint-suppression
Feb 11, 2026
Merged

Configure markdownlint to allow 2-space hard line breaks#124275
MihaZupan merged 4 commits intomizupan/uri-threatmodelsfrom
copilot/add-markdownlint-suppression

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

Description

Threat model files in System.Private.Uri/docs use 2 trailing spaces for hard line breaks (standard markdown syntax). Configured MD009 rule to recognize this instead of suppressing entire files.

Changes

  • Set br_spaces: 2 in .markdownlint.json to allow 2-space line breaks
  • Removed file-based suppression approach (.github/workflows/markdownlintignore)
  • Reverted workflow changes that referenced the removed ignore file

This properly handles the semantic meaning of trailing spaces rather than blanket-suppressing files from linting.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2026
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add markdownlint suppression for threat model files Add markdownlint suppression for System.Private.Uri threat model files Feb 11, 2026
Copilot AI requested a review from MihaZupan February 11, 2026 14:30
@MihaZupan MihaZupan marked this pull request as ready for review February 11, 2026 14:30
@MihaZupan MihaZupan requested review from a team and jeffhandley as code owners February 11, 2026 14:30
@MihaZupan
Copy link
Member

@copilot Let's configure markdownlint to ignore 2 spaces instead of suppressing individual files
See https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md009---trailing-spaces
The two spaces in this case are hard line breaks, not random spaces

Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 11, 2026

@copilot Let's configure markdownlint to ignore 2 spaces instead of suppressing individual files
See https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md009---trailing-spaces
The ...

Done! Changed approach to configure MD009's br_spaces parameter to allow 2 trailing spaces (hard line breaks) instead of suppressing individual files. Removed the markdownlintignore file and reverted workflow changes. (5661256)

Copilot AI changed the title Add markdownlint suppression for System.Private.Uri threat model files Configure markdownlint to allow 2 trailing spaces for hard line breaks Feb 11, 2026
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
@MihaZupan MihaZupan added this to the 11.0.0 milestone Feb 11, 2026
Copilot AI changed the title Configure markdownlint to allow 2 trailing spaces for hard line breaks Configure markdownlint to allow 2-space hard line breaks Feb 11, 2026
@MihaZupan MihaZupan merged commit fc6248f into mizupan/uri-threatmodels Feb 11, 2026
14 of 16 checks passed
@MihaZupan MihaZupan deleted the copilot/add-markdownlint-suppression branch February 11, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants