Extract ManifestBuilder and EventListener#124323
Merged
agocke merged 1 commit intodotnet:mainfrom Feb 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors System.Diagnostics.Tracing implementation by extracting large helper types out of EventSource.cs into dedicated files, reducing the size of EventSource.cs while preserving behavior.
Changes:
- Moved
ManifestBuilderimplementation intoManifestBuilder.cs. - Moved
EventListenerimplementation intoEventListener.cs. - Updated
System.Private.CoreLib.Shared.projitemsto compile the new files.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/ManifestBuilder.cs | New file containing the extracted ManifestBuilder implementation. |
| src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs | Removed in-file ManifestBuilder/EventListener definitions and kept remaining tracing types. |
| src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventListener.cs | New file containing the extracted EventListener implementation. |
| src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems | Adds the two new .cs files to the build. |
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/ManifestBuilder.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/ManifestBuilder.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventListener.cs
Show resolved
Hide resolved
This was referenced Feb 13, 2026
noahfalk
approved these changes
Feb 13, 2026
Member
Author
|
/ba-g failure is #124417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the size of the EventSource file, which I find helps reduce token usage