Skip to content

Comments

Extract ManifestBuilder and EventListener#124323

Merged
agocke merged 1 commit intodotnet:mainfrom
agocke:extract-manifestbuilder
Feb 17, 2026
Merged

Extract ManifestBuilder and EventListener#124323
agocke merged 1 commit intodotnet:mainfrom
agocke:extract-manifestbuilder

Conversation

@agocke
Copy link
Member

@agocke agocke commented Feb 12, 2026

This reduces the size of the EventSource file, which I find helps reduce token usage

Copilot AI review requested due to automatic review settings February 12, 2026 08:28
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors System.Diagnostics.Tracing implementation by extracting large helper types out of EventSource.cs into dedicated files, reducing the size of EventSource.cs while preserving behavior.

Changes:

  • Moved ManifestBuilder implementation into ManifestBuilder.cs.
  • Moved EventListener implementation into EventListener.cs.
  • Updated System.Private.CoreLib.Shared.projitems to compile the new files.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/ManifestBuilder.cs New file containing the extracted ManifestBuilder implementation.
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs Removed in-file ManifestBuilder/EventListener definitions and kept remaining tracing types.
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventListener.cs New file containing the extracted EventListener implementation.
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Adds the two new .cs files to the build.

@agocke
Copy link
Member Author

agocke commented Feb 17, 2026

/ba-g failure is #124417

@agocke agocke merged commit 54570b5 into dotnet:main Feb 17, 2026
150 of 156 checks passed
@agocke agocke deleted the extract-manifestbuilder branch February 17, 2026 18:59
@github-project-automation github-project-automation bot moved this to Done in AppModel Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants