Split assertionprop.cpp into integralrange.cpp and vnbasedmorph.cpp

[Copilot]

Description

Split assertionprop.cpp (6321 lines) into three focused compilation units for better code organization.

Changes

• integralrange.cpp (596 lines): All IntegralRange::* methods

  • Range computation, type bounds, cast analysis, symbolic arithmetic

• vnbasedmorph.cpp (1040 lines): VN-based optimization functions

  • optVNBasedFold* family (memset/memmove unrolling, expression folding)
  • optIsProfitableToSubstitute, optVNConstantPropOnJTrue
  • optVNAssertionPropCurStmt* assertion propagation
  • VNAssertionPropVisitorInfo struct

• assertionprop.cpp (4722 lines): Remaining assertion propagation infrastructure

  • AssertionPropFlowCallback dataflow analysis
  • optComputeAssertionGen, optAssertionPropMain
  • Assertion tracking and propagation core

Updated CMakeLists.txt to register new compilation units.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[EgorBo]

PTAL @dotnet/jit-contrib no diffs (except for some spurious diffs #124371) cleanup change. I just wanted to move unrelated to AssertionProp things out of assertionprop.cpp which is too big and hard to read:

• integralrange.cpp - 600 LOC related to IntegralRange class (used by multiple phases)
• vnbasedmorph.cpp - VN-based morph. It's when we iterate over all trees and perform constant foldings and other optimizations purely over VNs, no usages of any assertions, so like global morph but with VN. I moved the following functions there:

Compiler::optIsProfitableToSubstitute(...)
Compiler::optVNBasedFoldExpr_Call_Memset(...)
Compiler::optVNBasedFoldExpr_Call_Memmove(...)
Compiler::optVNBasedFoldExpr_Call(...)
Compiler::optVNBasedFoldExpr(...)
Compiler::optVNBasedFoldConstExpr(...)
Compiler::optVNBasedFoldCurStmt
Compiler::optVNConstantPropOnJTrue(...)
Compiler::optVnNonNullPropCurStmt(...)
Compiler::optVNAssertionPropCurStmtVisitor(...)
Compiler::optVNAssertionPropCurStmt(...)

Intentionally didn't try to wrap that into a separate phase or rename anything to avoid complicating the code-review.

I recommend reviewing with whitespaces disabled.

[Copilot]

Pull request overview

Refactors CoreCLR JIT assertion propagation by splitting the large assertionprop.cpp compilation unit into smaller, more focused units to improve code organization and maintainability.

Changes:

• Added integralrange.cpp containing all IntegralRange::* method implementations.
• Added vnbasedmorph.cpp containing VN-based folding/constant-prop and related visitors/helpers.
• Reduced assertionprop.cpp to the remaining assertion propagation infrastructure and updated CMakeLists.txt to compile the new units.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/coreclr/jit/vnbasedmorph.cpp	New compilation unit for VN-based folding and VN-driven assertion propagation.
src/coreclr/jit/integralrange.cpp	New compilation unit for IntegralRange implementation details.
src/coreclr/jit/assertionprop.cpp	Removes code moved into the new compilation units; retains assertion propagation core.
src/coreclr/jit/CMakeLists.txt	Registers the new .cpp files in the JIT build.

[jakobbotsch]

Does git blame -CCC still work with this? I had to move things in smaller batches when I did the importer to ensure that it could track lines across the files.

[EgorBo]

Does git blame -CCC still work with this? I had to move things in smaller batches when I did the importer to ensure that it could track lines across the files.

good point, let me do it by hands to ensure that