More precise ranges for casts in GetRangeFromAssertions#124415
Open
EgorBo wants to merge 3 commits intodotnet:mainfrom
Open
More precise ranges for casts in GetRangeFromAssertions#124415EgorBo wants to merge 3 commits intodotnet:mainfrom
EgorBo wants to merge 3 commits intodotnet:mainfrom
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves range analysis in the JIT's range check optimization pass by enabling more precise range propagation through cast operations and adding support for TYP_INT in GetRangeFromType.
Changes:
- Add early range tightening based on VN type for small types in GetRangeFromAssertions (though this appears to be dead code due to VN normalization)
- Change cast source type check from exact TYP_INT match to using genActualType, making the code more defensive
- Add TYP_INT case to GetRangeFromType to return the full int32 range instead of Unknown
3 tasks
EgorBo
force-pushed
the
precise-cast-ranges
branch
from
2704ba3 to
e492c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diffs