Skip to content

Build zstd with /source-charset:utf-8 option #124475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 3 commits into from
Feb 17, 2026
Merged

Build zstd with /source-charset:utf-8 option #124475

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f11e11
Avoid non-ascii charactor
kzrnm Feb 17, 2026
e028caf
Revert "Avoid non-ascii charactor"
kzrnm Feb 17, 2026
03623e8
Fix MSVC build of zlib
kzrnm Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/native/external/zstd.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,7 @@ if (ANDROID)
endif()

# disable warnings that occur in the zstd library
target_compile_options(libzstd_static PRIVATE $<$<COMPILE_LANG_AND_ID:C,Clang,AppleClang,GNU>:-Wno-implicit-fallthrough>)
target_compile_options(libzstd_static PRIVATE $<$<COMPILE_LANG_AND_ID:C,Clang,AppleClang,GNU>:-Wno-implicit-fallthrough>)

# Avoid errors caused by non-ASCII characters
target_compile_options(libzstd_static PRIVATE $<$<COMPILE_LANG_AND_ID:C,MSVC>:/source-charset:utf-8>)
Loading