[browser] Emit symbols in WasmSDK#124500
Merged
pavelsavara merged 3 commits intodotnet:mainfrom Feb 17, 2026
Merged
Conversation
maraf
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #122385 by enabling the WebAssembly SDK to properly emit symbol map files (.symbols files) to the build output. Previously, when WasmEmitSymbolMap=true was set, emscripten would generate the dotnet.native.js.symbols file, but the WasmSDK tasks would filter it out, leaving it only in the obj directory instead of promoting it to the build output.
Changes:
- Added
EmitSymbolMapproperty to build and publish asset computation tasks - Updated filtering logic to respect the
WasmEmitSymbolMapsetting instead of unconditionally filtering.symbolsfiles - Added fingerprinting support for
.symbolsfiles - Configured
.symbolsfiles to be treated as native WebAssembly resources
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs |
Added EmitSymbolMap property and passed it to the filtering helper method |
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmBuildAssets.cs |
Added EmitSymbolMap property, passed it to the filtering helper, and configured .symbols files as native WasmResource assets |
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs |
Updated ShouldFilterCandidate to accept emitSymbolMap parameter and changed filtering logic from always filtering .symbols files to only filtering when EmitSymbolMap is false |
src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets |
Wired up EmitSymbolMap property to both build and publish tasks, and added fingerprinting pattern for .symbols files |
Member
|
pavelsavara
approved these changes
Feb 17, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122385