Preserve ninja=false via msbuild#124562
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Feb 19, 2026
Merged
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
jkoritzinsky
approved these changes
Feb 19, 2026
steveisok
approved these changes
Feb 19, 2026
Member
|
/ba-g test failures unrelated to build change |
Member
|
/ba-g test failures unrelated to build change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating quoting issue, I found
build.sh -ninja falseis not honored via msbuild.The actual quoting fix is also included, so if we had space in dotnet path, it will be parsed by cmake correctly.