Write ExpectedExitCode marker in GenerateMarkerFiles#124582
Open
Write ExpectedExitCode marker in GenerateMarkerFiles#124582
Conversation
Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add expected exit code marker in GenerateMarkerFiles
Write ExpectedExitCode marker in GenerateMarkerFiles
Feb 19, 2026
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Feb 19, 2026
Open
APP_CRASH SIGABRT during coreclr_initialize on tvOS device (vm_map_enter allocation failure)
#123396
Open
Contributor
There was a problem hiding this comment.
Pull request overview
Adds generation of the ExpectedExitCode.txt marker during GenerateMarkerFiles so merged/standalone test payloads reliably carry the expected exit code alongside other marker files.
Changes:
- Adds a
MarkerFileitem for$(IntermediateOutputPath)\ExpectedExitCode.txtgated on$(ExpectedExitCode)being set and the build producing a merged or standalone runner (excludingSharedLibrary). - Writes
$(ExpectedExitCode)as the marker file content via the existingWriteLinesToFilemarker pipeline.
sbomer
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenerateMarkerFilesdid not emit the expected-exit-code marker, so merged/standalone test payloads could missExpectedExitCode.txt. This change adds marker generation directly in the existing marker pipeline.Scope
src/tests/Directory.Build.targetsinGenerateMarkerFiles.Behavior change
$(IntermediateOutputPath)\ExpectedExitCode.txt.$(ExpectedExitCode)as file content.$(ExpectedExitCode)is set$(CLRTestKind)is notSharedLibraryImplementation (minimal diff)
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.