Fix memory leak in Assembler::EmitGenericParamConstraints#124586
Open
tpa95 wants to merge 2 commits intodotnet:mainfrom
Open
Fix memory leak in Assembler::EmitGenericParamConstraints#124586tpa95 wants to merge 2 commits intodotnet:mainfrom
tpa95 wants to merge 2 commits intodotnet:mainfrom
Conversation
Free the per-parameter buffers stored in pConstraintsArr and pGPConstraintsArr before deleting the pointer arrays. Previously only the outer arrays were deleted, leaking the inner allocations for each type parameter.
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free the per-parameter buffers stored in
pConstraintsArrandpGPConstraintsArrbefore deleting the pointer arrays. Previously only the outer arrays were deleted, leaking the inner allocations for each type parameter.The errors were discovered using the Svace static analyzer. I didn't observe any in practice.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Reporter: Pavel Tikhomirov (Tihomirov-P@gaz-is.ru).
Organization: Gazinformservice (resp@gaz-is.ru).