Less optimistic checks for const vector to pattern checks#124599
Less optimistic checks for const vector to pattern checks#124599a74nh wants to merge 6 commits intodotnet:mainfrom
Conversation
Fixes dotnet#124511 When checking a element of TBase size, ensure that no other bits other than the first bit are set
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Pull request overview
This PR fixes a JIT bug in ARM64 SVE intrinsics where constant vector patterns were incorrectly validated, leading to wrong results. The issue was that EvaluateSimdMaskToPattern only checked the lowest bit of each mask element, allowing invalid masks with extra bits set to pass validation.
Changes:
- Enhanced mask validation to check all bits in each TBase-sized element, not just the lowest bit
- Renamed
finalOnetofirstZerofor clarity - Updated comments to better explain the mask format and validation logic
src/tests/JIT/Regression/JitBlue/Runtime_124511/Runtime_124511.csproj
Outdated
Show resolved
Hide resolved
src/tests/JIT/Regression/JitBlue/Runtime_124511/Runtime_124511.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
It should be added to the existing merged test csproj. I think you can follow what happened in this PR:
#123603
There was a problem hiding this comment.
(FWIW, we changed how regression tests are built in #121078)
There was a problem hiding this comment.
Done.
(FWIW, we changed how regression tests are built in #121078)
Is it still possible to run a just a single test using the new grouped method?
2 participants
Fixes #124511
When checking a element of TBase size, ensure that no other bits other than the first bit are set