[work-in-progress][API] RuntimeFeature.IsMultithreadingSupported#124603
Draft
pavelsavara wants to merge 6 commits intodotnet:mainfrom
Draft
[work-in-progress][API] RuntimeFeature.IsMultithreadingSupported#124603pavelsavara wants to merge 6 commits intodotnet:mainfrom
pavelsavara wants to merge 6 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new public API RuntimeFeature.IsMultithreadingSupported to replace the internal Thread.IsSingleThreaded property. This is part of API proposal #77541 to provide a public feature flag for determining if multithreading is supported on the current platform (particularly relevant for single-threaded WebAssembly environments).
Changes:
- Introduces public
RuntimeFeature.IsMultithreadingSupportedproperty and internalThrowIfMultithreadingIsNotSupported()method - Removes internal
Thread.IsSingleThreadedandThread.ThrowIfSingleThreaded() - Renames
PlatformDetection.IsThreadingSupported→IsMultithreadingSupportedandIsNotWasmThreadingSupported→IsNotMultithreadingSupported - Updates hundreds of test files to use the new naming convention
- Configures the feature switch in MSBuild targets for WebAssembly
Reviewed changes
Copilot reviewed 272 out of 272 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| System.Runtime.cs | Adds public API surface for IsMultithreadingSupported |
| RuntimeFeature.cs | Implements new property and internal throw helper |
| Thread.cs | Removes old IsSingleThreaded API |
| PlatformDetection.cs (multiple) | Updates to use RuntimeFeature instead of environment variable |
| Environment.cs | Uses new API for ProcessorCount logic |
| Microsoft.NET.Sdk.WebAssembly.Browser.targets | Configures feature switch for WASM |
| tests.browser.targets | Removes IsBrowserThreadingSupported environment variable |
| 200+ test files | Updates ConditionalFact/Theory attributes to use new naming |
This was referenced Feb 19, 2026
Open
Member
Can you do 1 boring prep PR that has just this rename and nothing else, and do the rest in this PR? It is hard to find any interesting changes in 250+ changed files. |
| NumericIntPtr => true, | ||
|
|
||
| nameof(IsDynamicCodeSupported) => IsDynamicCodeSupported, | ||
| nameof(IsDynamicCodeCompiled) => IsDynamicCodeCompiled, |
Contributor
There was a problem hiding this comment.
Suggested change
| nameof(IsDynamicCodeCompiled) => IsDynamicCodeCompiled, | |
| nameof(IsMultithreadingSupported) => IsMultithreadingSupported, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77541
Continuation of #123329
Mostly renames
Thread.IsSingleThreaded-> publicRuntimeFeature.IsMultithreadingSupportedThread.ThrowIfSingleThreaded()-> internalRuntimeFeature.ThrowIfMultithreadingIsNotSupported()PlatformDetection.IsThreadingSupported->PlatformDetection.IsMultithreadingSupportedPlatformDetection.IsNotWasmThreadingSupported->PlatformDetection.IsNotMultithreadingSupported