BackgroundService: create task using TaskCreationOptions.LongRunning to prevent thread pool starvation#124608
Open
srnwmnn wants to merge 2 commits intodotnet:mainfrom
Open
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates how the background
ExecuteAsyncmethod is started within theBackgroundService.Previously,
ExecuteAsyncwas launched usingTask.Run, which schedules work on the thread pool. This PR replaces that withTask.Factory.StartNewusingTaskCreationOptions.LongRunningandTaskScheduler.Default.Rationale
TaskCreationOptions.LongRunningsignals that the operation is expected to be long-lived, allowing the runtime to provision a dedicated thread instead of relying on the shared thread pool.ExecuteAsyncruns for the lifetime of the service.ExecuteAsynctask as before.Impact