Update OneCollect.RecordTrace to 0.1.33304 and re-enable UserEvents NativeAOT tests#124616
Update OneCollect.RecordTrace to 0.1.33304 and re-enable UserEvents NativeAOT tests#124616
Conversation
…ativeAOT tests Co-authored-by: mdh1418 <16830051+mdh1418@users.noreply.github.com>
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
|
@copilot most userevents tests are passing on the nativeAOT lane, validating the change. Since tests are still flakey we need the general disable, but we can leave the nativeAOT specific exclusion omitted |
Re-added the general |
There was a problem hiding this comment.
Pull request overview
Updates the OneCollect record-trace dependency and adjusts test gating so UserEvents tracing tests are no longer marked NativeAOT-incompatible, while keeping them generally disabled due to ongoing flakiness.
Changes:
- Bump
Microsoft.OneCollect.RecordTraceversion to0.1.33304. - Remove
NativeAotIncompatiblefromsrc/tests/tracing/usereventsto allow NativeAOT coverage again (when built in appropriate pipelines). - Keep
CLRTestTargetUnsupportedgating in place for the existing flakiness issue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
eng/Versions.props |
Updates MicrosoftOneCollectRecordTraceVersion to the new record-trace package version. |
src/tests/tracing/userevents/Directory.Build.props |
Removes NativeAotIncompatible so the UserEvents tests can participate in NativeAOT builds again (subject to existing gating). |
Description
Microsoft.OneCollect.RecordTrace0.1.33304(from thedotnet-diagnostics-testsfeed) contains the fix to detect .NET processes without perfmaps (one-collect#229), unblocking UserEvents tracing for NativeAOT.Changes:
eng/Versions.props: BumpMicrosoftOneCollectRecordTraceVersionfrom0.1.32221→0.1.33304src/tests/tracing/userevents/Directory.Build.props: RemoveNativeAotIncompatible(completing the [NativeAOT] Profilers unable to trace userevents from NativeAOT apps #123697 checklist). The generalCLRTestTargetUnsupporteddisable ([Test][UserEvents] Trace file does not contain expected events #123442) is kept since tests are still flaky — validated via/azp run runtime-nativeaot-outerloopthat NativeAOT UserEvents tests pass with the updated package.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.