Skip to content

Update OneCollect.RecordTrace to 0.1.33304 and re-enable UserEvents NativeAOT tests#124616

Open
Copilot wants to merge 3 commits intomainfrom
copilot/re-enable-user-events-runtime-tests
Open

Update OneCollect.RecordTrace to 0.1.33304 and re-enable UserEvents NativeAOT tests#124616
Copilot wants to merge 3 commits intomainfrom
copilot/re-enable-user-events-runtime-tests

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

Description

Microsoft.OneCollect.RecordTrace 0.1.33304 (from the dotnet-diagnostics-tests feed) contains the fix to detect .NET processes without perfmaps (one-collect#229), unblocking UserEvents tracing for NativeAOT.

Changes:


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…ativeAOT tests

Co-authored-by: mdh1418 <16830051+mdh1418@users.noreply.github.com>
Copilot AI changed the title [WIP] Update dotnet-diagnostics-tests feed and re-enable UserEvents tests Update OneCollect.RecordTrace to 0.1.33304 and re-enable UserEvents NativeAOT tests Feb 19, 2026
Copilot AI requested a review from mdh1418 February 19, 2026 19:48
@mdh1418
Copy link
Member

mdh1418 commented Feb 19, 2026

/azp run runtime-nativeaot-outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

@mdh1418
Copy link
Member

mdh1418 commented Feb 20, 2026

@copilot most userevents tests are passing on the nativeAOT lane, validating the change. Since tests are still flakey we need the general disable, but we can leave the nativeAOT specific exclusion omitted

)

Co-authored-by: mdh1418 <16830051+mdh1418@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 20, 2026

@copilot most userevents tests are passing on the nativeAOT lane, validating the change. Since tests are still flakey we need the general disable, but we can leave the nativeAOT specific exclusion omi...

Re-added the general CLRTestTargetUnsupported disable for #123442 while keeping NativeAotIncompatible removed. See commit 122fdf27.

@mdh1418 mdh1418 marked this pull request as ready for review February 20, 2026 16:03
Copilot AI review requested due to automatic review settings February 20, 2026 16:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OneCollect record-trace dependency and adjusts test gating so UserEvents tracing tests are no longer marked NativeAOT-incompatible, while keeping them generally disabled due to ongoing flakiness.

Changes:

  • Bump Microsoft.OneCollect.RecordTrace version to 0.1.33304.
  • Remove NativeAotIncompatible from src/tests/tracing/userevents to allow NativeAOT coverage again (when built in appropriate pipelines).
  • Keep CLRTestTargetUnsupported gating in place for the existing flakiness issue.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/Versions.props Updates MicrosoftOneCollectRecordTraceVersion to the new record-trace package version.
src/tests/tracing/userevents/Directory.Build.props Removes NativeAotIncompatible so the UserEvents tests can participate in NativeAOT builds again (subject to existing gating).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments