Skip unloadable-type tests under ReadyToRun; update ActiveIssue to #124031#124619
Merged
jtschuster merged 2 commits intomainfrom Feb 19, 2026
Merged
Skip unloadable-type tests under ReadyToRun; update ActiveIssue to #124031#124619jtschuster merged 2 commits intomainfrom
jtschuster merged 2 commits intomainfrom
Conversation
…4031 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update active issue attribute for TypeDescriptor tests
Skip unloadable-type tests under ReadyToRun; update ActiveIssue to #124031
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses test failures in System.ComponentModel.TypeConverter tests when running with ReadyToRun (R2R) compilation. R2R pre-compiled native code creates additional strong references that prevent garbage collection of collectible AssemblyLoadContext instances within the test's iteration limit, causing these unloadable-type tests to fail.
Changes:
jkotas
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R2R pre-compiled native code roots types loaded from a collectible
AssemblyLoadContext(via method tables, fixups, etc.), preventing GC from collecting the ALC within the test's 10-iteration limit.TypeDescriptor_WithCustomProvider_UnloadsUnloadableTypeswas missing the skip guard that its sibling already had; both tests also pointed to the now-closed issue #95928.Changes
TypeDescriptor_WithCustomProvider_UnloadsUnloadableTypes— add[ActiveIssue]to skip underIsReadyToRunCompiled, matching the sibling test's existing behaviorTypeDescriptor_WithDefaultProvider_UnloadsUnloadableTypes— update existing[ActiveIssue]from closed Enable Remaining Libraries Tests in TestReadyToRun Pipeline #95928 to open tracking issue Test failure: System.ComponentModel.Tests.TypeDescriptorTests.TypeDescriptor_WithCustomProvider_UnloadsUnloadableTypes #124031Both attributes now consistently reference #124031:
Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.