Skip to content

Implement SafeProcessHandle APIs for Linux and other Unixes #124979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Implement SafeProcessHandle APIs for Linux and other Unixes #124979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ac8197
Initial plan
Copilot Feb 27, 2026
525569a
Implement SafeProcessHandle APIs for Linux and other Unixes
Copilot Feb 27, 2026
160199f
Address code review: fix syscall return type handling
Copilot Feb 27, 2026
3e05167
Consolidate sys/syscall.h includes into single guard
Copilot Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/System.Diagnostics.Process/tests/SafeProcessHandleTests.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace System.Diagnostics.Tests
public partial class SafeProcessHandleTests
{
[Fact]
[PlatformSpecific(TestPlatforms.OSX)]
[PlatformSpecific(TestPlatforms.AnyUnix)]
public static void SendSignal_SIGTERM_TerminatesProcess()
{
using SafeProcessHandle processHandle = SafeProcessHandle.Start(CreateTenSecondSleep(), input: null, output: null, error: null);
Expand All @@ -29,7 +29,7 @@ public static void SendSignal_SIGTERM_TerminatesProcess()
}

[Fact]
[PlatformSpecific(TestPlatforms.OSX)]
[PlatformSpecific(TestPlatforms.AnyUnix)]
public static void SendSignal_SIGINT_TerminatesProcess()
{
using SafeProcessHandle processHandle = SafeProcessHandle.Start(CreateTenSecondSleep(), input: null, output: null, error: null);
Expand All @@ -43,7 +43,7 @@ public static void SendSignal_SIGINT_TerminatesProcess()
}

[Fact]
[PlatformSpecific(TestPlatforms.OSX)]
[PlatformSpecific(TestPlatforms.AnyUnix)]
public static void Signal_InvalidSignal_ThrowsArgumentOutOfRangeException()
{
using SafeProcessHandle processHandle = SafeProcessHandle.Start(CreateTenSecondSleep(), input: null, output: null, error: null);
Expand All @@ -57,7 +57,7 @@ public static void Signal_InvalidSignal_ThrowsArgumentOutOfRangeException()
}

[Fact]
[PlatformSpecific(TestPlatforms.OSX)]
[PlatformSpecific(TestPlatforms.AnyUnix)]
public static void SendSignal_ToExitedProcess_ThrowsWin32Exception()
{
ProcessStartOptions options = new("echo") { Arguments = { "test" } };
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Diagnostics.Process/tests/SafeProcessHandleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace System.Diagnostics.Tests
{
[PlatformSpecific(TestPlatforms.OSX | TestPlatforms.Windows)]
[PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Windows)]
public partial class SafeProcessHandleTests
{
private static ProcessStartOptions CreateTenSecondSleep()
Expand Down
5 changes: 5 additions & 0 deletions src/native/libs/Common/pal_config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@
#cmakedefine01 HAVE_GETGRGID_R
#cmakedefine01 HAVE_TERMIOS2
#cmakedefine01 HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR_NP
#cmakedefine01 HAVE_CLONE3
#cmakedefine01 HAVE_PIDFD_SEND_SIGNAL
#cmakedefine01 HAVE_CLOSE_RANGE
#cmakedefine01 HAVE_PDEATHSIG
#cmakedefine01 HAVE_SYS_TGKILL

// Mac OS X has stat64, but it is deprecated since plain stat now
// provides the same 64-bit aware struct when targeting OS X > 10.5
Expand Down
Loading
Loading