Skip to content

Fix getdomainname for SunOS #125053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gwr wants to merge 3 commits into
base: main
Choose a base branch
from
+42 −23
Open

Fix getdomainname for SunOS #125053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f316413
Fix getdomainname for SunOS
gwr Mar 2, 2026
7907fd5
Merge branch 'main' into gix-getdom
rzikm Mar 16, 2026
715ecb5
Apply code review suggestion
rzikm Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/native/libs/System.Native/extra_libs.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ macro(append_extra_system_libs NativeLibsExtra)
elseif (CLR_CMAKE_TARGET_OPENBSD)
list(APPEND ${NativeLibsExtra} pthread)
elseif (CLR_CMAKE_TARGET_SUNOS)
list(APPEND ${NativeLibsExtra} socket)
list(APPEND ${NativeLibsExtra} socket nsl)
elseif (CLR_CMAKE_TARGET_HAIKU)
list (APPEND ${NativeLibsExtra} network bsd)
endif ()
Expand Down
4 changes: 4 additions & 0 deletions src/native/libs/System.Native/pal_networking.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@
#include <stdio.h>
#endif
#include <unistd.h>
#if defined(TARGET_SUNOS) && HAVE_GETDOMAINNAME
// SunOS has getdomainname in libnsl but no header declaration
extern int getdomainname(char *name, int namelen);
#endif
#ifdef HAVE_PWD_H
#include <pwd.h>
#endif
Expand Down
59 changes: 37 additions & 22 deletions src/native/libs/configure.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,29 +977,44 @@ check_symbol_exists(
"unistd.h;sys/types.h;sys/socket.h"
HAVE_GETPEEREID)

check_symbol_exists(
getdomainname
unistd.h
HAVE_GETDOMAINNAME)
set (PREVIOUS_CMAKE_REQUIRED_LIBRARIES ${CMAKE_REQUIRED_LIBRARIES})
if (CLR_CMAKE_TARGET_SUNOS)
# On SunOS, getdomainname is in libnsl but not declared in any header
set(CMAKE_REQUIRED_LIBRARIES socket nsl)
check_function_exists(
getdomainname
HAVE_GETDOMAINNAME)
else()
check_symbol_exists(
getdomainname
unistd.h
HAVE_GETDOMAINNAME)
endif()

# getdomainname on OSX takes an 'int' instead of a 'size_t'
# check if compiling with 'size_t' would cause a warning
set (PREVIOUS_CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS})
set (CMAKE_REQUIRED_FLAGS "-Werror -Weverything")
check_c_source_compiles(
"
#include <unistd.h>
int main(void)
{
size_t namelen = 20;
char name[20];
int dummy = getdomainname(name, namelen);
(void)dummy;
return 0;
}
"
HAVE_GETDOMAINNAME_SIZET)
set (CMAKE_REQUIRED_FLAGS ${PREVIOUS_CMAKE_REQUIRED_FLAGS})
# Some platforms (e.g. macOS, SunOS) define getdomainname with an 'int' length parameter
# Check whether using 'size_t' for the length parameter would cause a warning
if (CLR_CMAKE_TARGET_SUNOS)
# SunOS uses int, not size_t
set (HAVE_GETDOMAINNAME_SIZET 0)
else()
set (PREVIOUS_CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS})
set (CMAKE_REQUIRED_FLAGS "-Werror -Weverything")
check_c_source_compiles(
"
#include <unistd.h>
int main(void)
{
size_t namelen = 20;
char name[20];
int dummy = getdomainname(name, namelen);
(void)dummy;
return 0;
}
"
HAVE_GETDOMAINNAME_SIZET)
set (CMAKE_REQUIRED_FLAGS ${PREVIOUS_CMAKE_REQUIRED_FLAGS})
endif()
set (CMAKE_REQUIRED_LIBRARIES ${PREVIOUS_CMAKE_REQUIRED_LIBRARIES})

set (PREVIOUS_CMAKE_REQUIRED_LIBRARIES ${CMAKE_REQUIRED_LIBRARIES})
if (HAVE_SYS_INOTIFY_H AND (CLR_CMAKE_TARGET_FREEBSD OR CLR_CMAKE_TARGET_OPENBSD))
Expand Down
Loading