Skip to content

Fix ManagedNTLM failures on Big endian architecture. #125103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShreyaLaxminarayan wants to merge 2 commits into from
Closed

Fix ManagedNTLM failures on Big endian architecture. #125103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
091b9b4
Fix ManagedNTLM faiures on Big endian architectures
ShreyaLaxminarayan Mar 3, 2026
2dd63fb
Merge branch 'main' into ntlmfixes
ShreyaLaxminarayan Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.ManagedNtlm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ private unsafe struct MessageField
private int _payloadOffset;
public int PayloadOffset
{
readonly get =>BitConverter.IsLittleEndian? _payloadOffset: BinaryPrimitives.ReverseEndianness(_payloadOffset);
set =>_payloadOffset = BitConverter.IsLittleEndian? value: BinaryPrimitives.ReverseEndianness(value);
readonly get => BitConverter.IsLittleEndian? _payloadOffset: BinaryPrimitives.ReverseEndianness(_payloadOffset);
set => _payloadOffset = BitConverter.IsLittleEndian? value: BinaryPrimitives.ReverseEndianness(value);
}
}

Expand All @@ -158,8 +158,8 @@ private unsafe struct Version
public byte CurrentRevision;
public ushort ProductBuild
{
readonly get =>BitConverter.IsLittleEndian? _productBuild: BinaryPrimitives.ReverseEndianness(_productBuild);
set =>_productBuild = BitConverter.IsLittleEndian? value: BinaryPrimitives.ReverseEndianness(value);
readonly get => BitConverter.IsLittleEndian? _productBuild: BinaryPrimitives.ReverseEndianness(_productBuild);
set => _productBuild = BitConverter.IsLittleEndian? value: BinaryPrimitives.ReverseEndianness(value);
}
}

Expand All @@ -174,8 +174,8 @@ private unsafe struct NegotiateMessage
public Version Version;
public Flags Flags
{
readonly get =>BitConverter.IsLittleEndian? _flags: (Flags)BinaryPrimitives.ReverseEndianness((uint)_flags);
set =>_flags = BitConverter.IsLittleEndian? value: (Flags)BinaryPrimitives.ReverseEndianness((uint)value);
readonly get => BitConverter.IsLittleEndian? _flags: (Flags)BinaryPrimitives.ReverseEndianness((uint)_flags);
set => _flags = BitConverter.IsLittleEndian? value: (Flags)BinaryPrimitives.ReverseEndianness((uint)value);
}
}

Expand All @@ -185,8 +185,13 @@ private unsafe struct ChallengeMessage
{
public MessageHeader Header;
public MessageField TargetName;
public Flags Flags;
public fixed byte ServerChallenge[ChallengeLength];
private Flags _flags;
public Flags Flags
{
readonly get => BitConverter.IsLittleEndian? _flags: (Flags)BinaryPrimitives.ReverseEndianness((uint)_flags);
set => _flags = BitConverter.IsLittleEndian? value: (Flags)BinaryPrimitives.ReverseEndianness((uint)value);
}
private ulong _unused;
public MessageField TargetInfo;
public Version Version;
Expand All @@ -203,7 +208,12 @@ private unsafe struct AuthenticateMessage
public MessageField UserName;
public MessageField Workstation;
public MessageField EncryptedRandomSessionKey;
public Flags Flags;
private Flags _flags;
public Flags Flags
{
readonly get => BitConverter.IsLittleEndian? _flags: (Flags)BinaryPrimitives.ReverseEndianness((uint)_flags);
set => _flags = BitConverter.IsLittleEndian? value: (Flags)BinaryPrimitives.ReverseEndianness((uint)value);
}
public Version Version;
public fixed byte Mic[16];
}
Expand Down Expand Up @@ -589,7 +599,7 @@ private static byte[] DeriveKey(ReadOnlySpan<byte> exportedSessionKey, ReadOnlyS
return null;
}

Flags flags = BitConverter.IsLittleEndian ? challengeMessage.Flags : (Flags)BinaryPrimitives.ReverseEndianness((uint)challengeMessage.Flags);
Flags flags = challengeMessage.Flags;
ReadOnlySpan<byte> targetName = GetField(challengeMessage.TargetName, blob);

// Only NTLMv2 with MIC is supported
Expand Down
Loading