Conversation
|
Tagging subscribers to this area: @steveisok, @dotnet/area-system-diagnostics |
There was a problem hiding this comment.
Pull request overview
This PR re-enables an async stack trace theory test on ARM by removing a platform-specific [ActiveIssue] quarantine from System.Diagnostics.StackTrace tests.
Changes:
- Removed the
[ActiveIssue(..., IsArmProcess)]attribute fromToString_Async, so the test now runs on ARM when async is supported.
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
|
/ba-g test failures are on arm64/coreclr while this change only affects arm32/naot |
In RhpThrowImpl, before calling INLINE_GETTHREAD we were saving the caller-saved register r0 but we should save r2 as well since it contains the exception kind. Fixes #123979. --------- Co-authored-by: Eduardo Velarde <evelardepola@microsoft.com> Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
In RhpThrowImpl, before calling INLINE_GETTHREAD we were saving the caller-saved register r0 but we should save r2 as well since it contains the exception kind (it's placed in r2 by RhpThrowEx/RhpThrowExact).
Fixes #123979.