Remove unnecessary volatile from fields in Libraries

src/libraries/Common/src/Interop/Unix/System.Native/Interop.MemfdCreate.cs

@@ -15,7 +15,7 @@ internal static partial class Sys
         [LibraryImport(Libraries.SystemNative, EntryPoint = "SystemNative_IsMemfdSupported", SetLastError = true)]
         private static partial int MemfdSupportedImpl();
 
-        private static volatile NullableBool s_memfdSupported;
+        private static NullableBool s_memfdSupported;
 
         internal static bool IsMemfdSupported
         {

src/libraries/Common/src/System/Console/ConsoleUtils.cs

@@ -6,7 +6,7 @@ namespace System
     internal static partial class ConsoleUtils
     {
         /// <summary>Whether to output ansi color strings.</summary>
-        private static volatile NullableBool s_emitAnsiColorCodes;
+        private static NullableBool s_emitAnsiColorCodes;
 
         /// <summary>Get whether to emit ANSI color codes.</summary>
         public static bool EmitAnsiColorCodes

src/libraries/Common/src/System/Security/Cryptography/Pkcs/Pkcs9ContentType.cs

@@ -62,6 +62,6 @@ public override void CopyFrom(AsnEncodedData asnEncodedData)
             return new Oid(contentTypeValue);
         }
 
-        private volatile Oid? _lazyContentType;
+        private Oid? _lazyContentType;
     }
 }

src/libraries/Common/src/System/Security/Cryptography/Pkcs/Pkcs9DocumentDescription.cs

@@ -81,6 +81,6 @@ private static byte[] Encode(string documentDescription)
             return PkcsHelpers.EncodeOctetString(octets);
         }
 
-        private volatile string? _lazyDocumentDescription;
+        private string? _lazyDocumentDescription;
     }
 }

src/libraries/Common/src/System/Security/Cryptography/Pkcs/Pkcs9DocumentName.cs

@@ -81,6 +81,6 @@ private static byte[] Encode(string documentName)
             return PkcsHelpers.EncodeOctetString(octets);
         }
 
-        private volatile string? _lazyDocumentName;
+        private string? _lazyDocumentName;
     }
 }

src/libraries/Common/src/System/Security/Cryptography/Pkcs/Pkcs9MessageDigest.cs

@@ -60,6 +60,6 @@ public override void CopyFrom(AsnEncodedData asnEncodedData)
             return PkcsHelpers.DecodeOctetString(rawData);
         }
 
-        private volatile byte[]? _lazyMessageDigest;
+        private byte[]? _lazyMessageDigest;
     }
 }

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/ApplicationCatalog.cs

@@ -15,7 +15,7 @@ namespace System.ComponentModel.Composition.Hosting
     public partial class ApplicationCatalog : ComposablePartCatalog, ICompositionElement
     {
         private bool _isDisposed;
-        private volatile AggregateCatalog? _innerCatalog;
+        private AggregateCatalog? _innerCatalog;
         private readonly object _thisLock = new object();
         private readonly ICompositionElement? _definitionOrigin;
         private readonly ReflectionContext? _reflectionContext;

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/AssemblyCatalog.cs

@@ -24,8 +24,8 @@ public class AssemblyCatalog : ComposablePartCatalog, ICompositionElement
     {
         private readonly object _thisLock = new object();
         private readonly ICompositionElement _definitionOrigin;
-        private volatile Assembly _assembly;
-        private volatile ComposablePartCatalog? _innerCatalog;
+        private Assembly _assembly;
+        private ComposablePartCatalog? _innerCatalog;
         private int _isDisposed;
 
         private readonly ReflectionContext? _reflectionContext;

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/TypeCatalog.cs

@@ -26,7 +26,7 @@ public class TypeCatalog : ComposablePartCatalog, ICompositionElement
     {
         private readonly object _thisLock = new object();
         private Type[]? _types;
-        private volatile List<ComposablePartDefinition>? _parts;
+        private List<ComposablePartDefinition>? _parts;
         private volatile bool _isDisposed;
         private readonly ICompositionElement _definitionOrigin;
         private readonly Lazy<Dictionary<string, List<ComposablePartDefinition>>> _contractPartIndex;

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Primitives/ComposablePartCatalog.cs

@@ -22,7 +22,7 @@ namespace System.ComponentModel.Composition.Primitives
     public abstract class ComposablePartCatalog : IEnumerable<ComposablePartDefinition>, IDisposable
     {
         private bool _isDisposed;
-        private volatile IQueryable<ComposablePartDefinition>? _queryableParts;
+        private IQueryable<ComposablePartDefinition>? _queryableParts;
 
         internal static readonly List<Tuple<ComposablePartDefinition, ExportDefinition>> _EmptyExportsList = new List<Tuple<ComposablePartDefinition, ExportDefinition>>();
 

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Primitives/Export.cs

@@ -18,7 +18,7 @@ public class Export
         private readonly ExportDefinition? _definition;
         private readonly Func<object?>? _exportedValueGetter;
         private static readonly object _EmptyValue = new object();
-        private volatile object? _exportedValue = Export._EmptyValue;
+        private object? _exportedValue = Export._EmptyValue;
 
         /// <summary>
         ///     Initializes a new instance of the <see cref="Export"/> class.

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePart.cs

@@ -16,9 +16,9 @@ namespace System.ComponentModel.Composition.ReflectionModel
     internal class ReflectionComposablePart : ComposablePart, ICompositionElement
     {
         private readonly ReflectionComposablePartDefinition _definition;
-        private volatile Dictionary<ImportDefinition, object?>? _importValues;
-        private volatile Dictionary<ImportDefinition, ImportingItem>? _importsCache;
-        private volatile Dictionary<int, ExportingMember>? _exportsCache;
+        private Dictionary<ImportDefinition, object?>? _importValues;
+        private Dictionary<ImportDefinition, ImportingItem>? _importsCache;
+        private Dictionary<int, ExportingMember>? _exportsCache;
         private volatile bool _invokeImportsSatisfied = true;
         private bool _initialCompositionComplete;
         private volatile object? _cachedInstance;

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartDefinition.cs

@@ -15,10 +15,10 @@ internal sealed class ReflectionComposablePartDefinition : ComposablePartDefinit
     {
         private readonly IReflectionPartCreationInfo _creationInfo;
 
-        private volatile ImportDefinition[]? _imports;
-        private volatile ExportDefinition[]? _exports;
-        private volatile IDictionary<string, object?>? _metadata;
-        private volatile ConstructorInfo? _constructor;
+        private ImportDefinition[]? _imports;
+        private ExportDefinition[]? _exports;
+        private IDictionary<string, object?>? _metadata;
+        private ConstructorInfo? _constructor;
         private readonly object _lock = new object();
 
         public ReflectionComposablePartDefinition(IReflectionPartCreationInfo creationInfo)

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/BooleanConverter.cs

@@ -10,7 +10,7 @@ namespace System.ComponentModel
     /// </summary>
     public class BooleanConverter : TypeConverter
     {
-        private static volatile StandardValuesCollection? s_values;
+        private static StandardValuesCollection? s_values;
 
         /// <summary>
         /// Gets a value indicating whether this converter can convert an object

src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/LicenseManager.cs

@@ -19,10 +19,10 @@ public sealed partial class LicenseManager
     {
         private static readonly object s_selfLock = new object();
 
-        private static volatile LicenseContext? s_context;
+        private static LicenseContext? s_context;
         private static object? s_contextLockHolder;
-        private static volatile Hashtable? s_providers;
-        private static volatile Hashtable? s_providerInstances;
+        private static Hashtable? s_providers;
+        private static Hashtable? s_providerInstances;
         private static readonly object s_internalSyncObject = new object();
 
         // not creatable...

src/libraries/System.Composition.Hosting/src/System/Composition/Hosting/Core/ExportDescriptorRegistry.cs

@@ -10,7 +10,7 @@ internal sealed class ExportDescriptorRegistry
     {
         private readonly object _thisLock = new object();
         private readonly ExportDescriptorProvider[] _exportDescriptorProviders;
-        private volatile Dictionary<CompositionContract, ExportDescriptor[]> _partDefinitions = new Dictionary<CompositionContract, ExportDescriptor[]>();
+        private Dictionary<CompositionContract, ExportDescriptor[]> _partDefinitions = new Dictionary<CompositionContract, ExportDescriptor[]>();
 
         public ExportDescriptorRegistry(ExportDescriptorProvider[] exportDescriptorProviders)
         {

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/AppSettingsSection.cs

@@ -9,9 +9,9 @@ namespace System.Configuration
 {
     public sealed class AppSettingsSection : ConfigurationSection
     {
-        private static volatile ConfigurationPropertyCollection s_properties;
-        private static volatile ConfigurationProperty s_propAppSettings;
-        private static volatile ConfigurationProperty s_propFile;
+        private static ConfigurationPropertyCollection s_properties;
+        private static ConfigurationProperty s_propAppSettings;
+        private static ConfigurationProperty s_propFile;
 
         private KeyValueInternalCollection _keyValueCollection;
 

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ClientConfigPaths.cs

@@ -23,7 +23,7 @@ internal sealed class ClientConfigPaths
         private const string UrlDesc = "Url";
         private const string PathDesc = "Path";
 
-        private static volatile ClientConfigPaths s_current;
+        private static ClientConfigPaths s_current;
         private static volatile bool s_currentIncludesUserConfig;
 
         private readonly bool _includesUserConfig;

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ClientConfigurationHost.cs

@@ -25,7 +25,7 @@ internal sealed class ClientConfigurationHost : DelegatingConfigHost, IInternalC
         private const string MachineConfigSubdirectory = "Config";
 
         private static readonly object s_version = new object();
-        private static volatile string s_machineConfigFilePath;
+        private static string s_machineConfigFilePath;
         private ClientConfigPaths _configPaths; // physical paths to client config files
 
         private string _exePath; // the physical path to the exe being configured

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ClientSettingsStore.cs

@@ -222,7 +222,7 @@ private sealed class ClientSettingsConfigurationHost : DelegatingConfigHost
         {
             private const string ClientConfigurationHostTypeName = "System.Configuration.ClientConfigurationHost, " + TypeUtil.ConfigurationManagerAssemblyName;
             private const string InternalConfigConfigurationFactoryTypeName = "System.Configuration.Internal.InternalConfigConfigurationFactory, " + TypeUtil.ConfigurationManagerAssemblyName;
-            private static volatile IInternalConfigConfigurationFactory s_configFactory;
+            private static IInternalConfigConfigurationFactory s_configFactory;
 
             /// <summary>
             /// ClientConfigurationHost implements this - a way of getting some info from it without

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationElement.cs

@@ -40,7 +40,7 @@ public abstract class ConfigurationElement
         };
 
         private static readonly Hashtable s_propertyBags = new Hashtable();
-        private static volatile Dictionary<Type, ConfigurationValidatorBase> s_perTypeValidators;
+        private static Dictionary<Type, ConfigurationValidatorBase> s_perTypeValidators;
         internal static readonly object s_nullPropertyValue = new object();
 
         private static readonly ConfigurationElementProperty s_elementProperty =
@@ -52,7 +52,7 @@ public abstract class ConfigurationElement
         internal BaseConfigurationRecord _configRecord;
         private ConfigurationElementProperty _elementProperty = s_elementProperty;
         internal ContextInformation _evalContext;
-        private volatile ElementInformation _evaluationElement;
+        private ElementInformation _evaluationElement;
         internal ConfigurationValueFlags _itemLockedFlag;
         internal ConfigurationLockCollection _lockedAllExceptAttributesList;
         internal ConfigurationLockCollection _lockedAllExceptElementsList;

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationManagerInternalFactory.cs

@@ -7,7 +7,7 @@ namespace System.Configuration
 {
     internal static class ConfigurationManagerInternalFactory
     {
-        private static volatile IConfigurationManagerInternal s_instance;
+        private static IConfigurationManagerInternal s_instance;
 
         internal static IConfigurationManagerInternal Instance => s_instance ??= new ConfigurationManagerInternal();
     }

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationValues.cs

@@ -8,7 +8,7 @@ namespace System.Configuration
 {
     internal sealed class ConfigurationValues : NameObjectCollectionBase
     {
-        private static volatile IEnumerable s_emptyCollection;
+        private static IEnumerable s_emptyCollection;
         private BaseConfigurationRecord _configRecord;
         private volatile bool _containsElement;
         private volatile bool _containsInvalidValue;

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/DefaultSection.cs

@@ -7,7 +7,7 @@ namespace System.Configuration
 {
     public sealed class DefaultSection : ConfigurationSection
     {
-        private static volatile ConfigurationPropertyCollection s_properties;
+        private static ConfigurationPropertyCollection s_properties;
         private bool _isModified;
 
         private string _rawXml = string.Empty;

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/EmptyImpersonationContext.cs

@@ -6,7 +6,7 @@ namespace System.Configuration
     // Used in cases where the Host does not require impersonation.
     internal sealed class EmptyImpersonationContext : IDisposable
     {
-        private static volatile IDisposable s_emptyImpersonationContext;
+        private static IDisposable s_emptyImpersonationContext;
 
         public void Dispose() { }
 

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/IgnoreSection.cs

@@ -7,7 +7,7 @@ namespace System.Configuration
 {
     public sealed class IgnoreSection : ConfigurationSection
     {
-        private static volatile ConfigurationPropertyCollection s_properties;
+        private static ConfigurationPropertyCollection s_properties;
         private bool _isModified;
 
         private string _rawXml = string.Empty;

src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/SettingValueElement.cs

@@ -7,7 +7,7 @@ namespace System.Configuration
 {
     public sealed class SettingValueElement : ConfigurationElement
     {
-        private static volatile ConfigurationPropertyCollection _properties;
+        private static ConfigurationPropertyCollection _properties;
         private static readonly XmlDocument _document = new XmlDocument();
 
         private XmlNode _valueXml;

src/libraries/System.Configuration.ConfigurationManager/src/System/Diagnostics/DiagnosticsConfiguration.cs

@@ -8,7 +8,7 @@ namespace System.Diagnostics
 {
     internal static class DiagnosticsConfiguration
     {
-        private static volatile SystemDiagnosticsSection s_configSection;
+        private static SystemDiagnosticsSection s_configSection;
         private static volatile InitState s_initState = InitState.NotInitialized;
 
         // Setting for Switch.switchSetting

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DsesFilterAndTransform.cs

@@ -971,7 +971,7 @@ public EnumeratePropertyFetch(Type type) : base(type) { }
 
             private readonly DiagnosticSourceEventSource _eventSource;
             private readonly string _propertyName;
-            private volatile PropertyFetch? _fetchForExpectedType;
+            private PropertyFetch? _fetchForExpectedType;
             #endregion
         }
 

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/AggregatorStore.cs

@@ -56,8 +56,8 @@ internal struct AggregatorStore<TAggregator> where TAggregator : Aggregator
         // FixedSizeLabelNameDictionary<StringSequence3, ConcurrentDictionary<ObjectSequence3, TAggregator>>
         // FixedSizeLabelNameDictionary<StringSequenceMany, ConcurrentDictionary<ObjectSequenceMany, TAggregator>>
         // MultiSizeLabelNameDictionary<TAggregator> - this is used when we need to store more than one of the above union items
-        private volatile object? _stateUnion;
-        private volatile AggregatorLookupFunc<TAggregator>? _cachedLookupFunc;
+        private object? _stateUnion;
+        private AggregatorLookupFunc<TAggregator>? _cachedLookupFunc;
         private readonly Func<TAggregator?> _createAggregatorFunc;
 
         public AggregatorStore(Func<TAggregator?> createAggregator)

src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/PerformanceCounterLib.cs

@@ -44,9 +44,9 @@ internal sealed class PerformanceCounterLib
         private const string LanguageKeyword = "language";
         private const string DllName = "netfxperf.dll";
 
-        private static volatile string s_computerName;
-        private static volatile string s_iniFilePath;
-        private static volatile string s_symbolFilePath;
+        private static string s_computerName;
+        private static string s_iniFilePath;
+        private static string s_symbolFilePath;
 
         private static CultureInfo? s_englishCulture;
 
@@ -55,7 +55,7 @@ internal sealed class PerformanceCounterLib
         private readonly string _perfLcid;
 
 
-        private static volatile Hashtable s_libraryTable;
+        private static Hashtable s_libraryTable;
         private Hashtable _customCategoryTable;
         private Hashtable _categoryTable;
         private Hashtable _nameTable;

src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/SharedPerformanceCounter.cs

@@ -27,7 +27,7 @@ internal sealed unsafe class SharedPerformanceCounter
 
         private static long s_lastInstanceLifetimeSweepTick;
         private const long InstanceLifetimeSweepWindow = 30 * 10000000; //ticks
-        private static volatile ProcessData s_procData;
+        private static ProcessData s_procData;
 
         private static ProcessData ProcessData
         {

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Linux.cs

@@ -9,7 +9,7 @@ namespace System.Diagnostics
 {
     internal static partial class ProcessManager
     {
-        private static volatile NullableBool _procMatchesPidNamespace;
+        private static NullableBool _procMatchesPidNamespace;
 
         /// <summary>Gets the IDs of all processes on the current machine.</summary>
         public static int[] GetProcessIds() => new List<int>(EnumerateProcessIds()).ToArray();

src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/Expression.cs

@@ -29,7 +29,7 @@ public abstract partial class Expression
         internal const string DelegateCreationRequiresDynamicCode = "Delegate creation requires dynamic code generation.";
 
         private static readonly CacheDict<Type, MethodInfo> s_lambdaDelegateCache = new CacheDict<Type, MethodInfo>(40);
-        private static volatile CacheDict<Type, Func<Expression, string?, bool, ReadOnlyCollection<ParameterExpression>, LambdaExpression>>? s_lambdaFactories;
+        private static CacheDict<Type, Func<Expression, string?, bool, ReadOnlyCollection<ParameterExpression>, LambdaExpression>>? s_lambdaFactories;
 
         // For 4.0, many frequently used Expression nodes have had their memory
         // footprint reduced by removing the Type and NodeType fields. This has

src/libraries/System.Linq.Expressions/src/System/Runtime/CompilerServices/CallSite.cs

@@ -51,7 +51,7 @@ public class CallSite
         /// <summary>
         /// Cache of CallSite constructors for a given delegate type.
         /// </summary>
-        private static volatile CacheDict<Type, Func<CallSiteBinder, CallSite>>? s_siteCtors;
+        private static CacheDict<Type, Func<CallSiteBinder, CallSite>>? s_siteCtors;
 
         /// <summary>
         /// The Binder responsible for binding operations at this call site.
@@ -162,7 +162,7 @@ public T Update
         private static T? s_cachedUpdate;
 
         // Cached noMatch delegate for all sites with a given T
-        private static volatile T? s_cachedNoMatch;
+        private static T? s_cachedNoMatch;
 
         [RequiresDynamicCode(Expression.NewArrayRequiresDynamicCode)]
         private CallSite(CallSiteBinder binder)

src/libraries/System.Linq.Parallel/src/System/Linq/Parallel/Enumerables/EmptyEnumerable.cs

@@ -27,8 +27,8 @@ private EmptyEnumerable()
         }
 
         // A singleton cached and shared among callers.
-        private static volatile EmptyEnumerable<T>? s_instance;
-        private static volatile EmptyEnumerator<T>? s_enumeratorInstance;
+        private static EmptyEnumerable<T>? s_instance;
+        private static EmptyEnumerator<T>? s_enumeratorInstance;
 
         internal static EmptyEnumerable<T> Instance =>
             // There is no need for thread safety here.

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.cs

@@ -19,7 +19,7 @@ internal static partial class AuthenticationHelper
         private const string UsePortInSpnCtxSwitch = "System.Net.Http.UsePortInSpn";
         private const string UsePortInSpnEnvironmentVariable = "DOTNET_SYSTEM_NET_HTTP_USEPORTINSPN";
 
-        private static volatile NullableBool s_usePortInSpn;
+        private static NullableBool s_usePortInSpn;
 
         private static bool UsePortInSpn
         {

src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs

@@ -15,7 +15,7 @@ namespace System.Net
 {
     internal static partial class NameResolutionPal
     {
-        private static volatile NullableBool s_getAddrInfoExSupported;
+        private static NullableBool s_getAddrInfoExSupported;
 
         public static bool SupportsGetAddrInfoAsync
         {