Skip to content

[NO-MERGE, NO-REVIEW] Experiment: try remove test exclusions #125335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mrek-msft wants to merge 4 commits into
base: main
Choose a base branch
from
+0 −8
Draft

[NO-MERGE, NO-REVIEW] Experiment: try remove test exclusions #125335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fac028
try remove test exclusions
mrek-msft Mar 3, 2026
1ce98a6
try broke test
mrek-msft Mar 9, 2026
5e921d6
comment out temporary dead code
mrek-msft Mar 10, 2026
e3c3ed3
Remove experimental code and remove remaining ActiveIssues
mrek-msft Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...raries/Microsoft.Extensions.Configuration.UserSecrets/tests/ConfigurationExtensionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ private void SetSecret(string id, string key, string value)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void AddUserSecrets_FindsAssemblyAttribute()
{
var randValue = Guid.NewGuid().ToString();
Expand All @@ -67,7 +66,6 @@ public void AddUserSecrets_FindsAssemblyAttribute()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void AddUserSecrets_FindsAssemblyAttributeFromType()
{
Comment on lines 68 to 70
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-enabling this test on iOS/tvOS can still fail because it depends on PathHelper.GetSecretsPathFromSecretsId finding a user profile location (APPDATA/HOME/SpecialFolder paths). Consider setting DOTNET_USER_SECRETS_FALLBACK_DIR to a temp directory during the test run (and restoring it) to avoid platform-specific failures, or keep the platform exclusion.

Copilot uses AI. Check for mistakes.
var randValue = Guid.NewGuid().ToString();
Expand Down Expand Up @@ -121,7 +119,6 @@ public void AddUserSecrets_DoesThrowsIfNotOptionalAndSecretDoesNotExist()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60584", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void AddUserSecrets_With_SecretsId_Passed_Explicitly()
{
Comment on lines 121 to 123
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-enabling this test on iOS/tvOS may still fail if PathHelper.GetSecretsPathFromSecretsId cannot resolve a user-secrets root and throws InvalidOperationException. Consider forcing a writable user-secrets root for tests via DOTNET_USER_SECRETS_FALLBACK_DIR (temp directory) or keep the platform exclusion until the platform behavior is addressed.

Copilot uses AI. Check for mistakes.
var userSecretsId = Guid.NewGuid().ToString();
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ArrayTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public class ArrayTests : IDisposable
";

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void DifferentConfigSources_Merged_KeysAreSorted()
{
var config = BuildConfig();
Comment on lines 49 to 52
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Apple mobile the constructor writes the config files under Path.GetTempPath(), but BuildConfig() adds sources using only the file names and does not set the builder base path to that temp directory. When this test is re-enabled on iOS/tvOS, the providers will look under the default base path (typically AppContext.BaseDirectory) and won't find the temp files. Fix by setting the base path/file provider to the directory you wrote the files into (and track full paths for cleanup), or keep the platform exclusion.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -76,7 +75,6 @@ public void DifferentConfigSources_Merged_KeysAreSorted()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void DifferentConfigSources_Merged_WithOverwrites()
{
Comment on lines 77 to 79
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same Apple mobile path issue as the earlier test: files may be created under Path.GetTempPath() but BuildConfig() reads from the default base path when only file names are provided. Re-enabling on iOS/tvOS without setting the builder base path will make this test fail to locate its inputs.

Copilot uses AI. Check for mistakes.
var config = BuildConfig();
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ public IConfigurationProvider Build(IConfigurationBuilder builder)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void OnLoadErrorWillBeCalledOnJsonParseError()
{
_fileSystem.WriteFile(Path.Combine(_basePath, "error.json"), @"{""JsonKey1"": ", absolute: true);
Comment on lines 360 to 363
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test writes error.json to _basePath (AppContext.BaseDirectory) via absolute: true. Re-enabling it on iOS/tvOS (by removing the ActiveIssue) is likely to fail because the app base directory is generally not writable on those platforms. Use the existing _fileSystem.RootPath/_fileProvider for writable test files (or another temp location) and ensure the configuration builder is pointed at that path, or keep the platform exclusion.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -863,7 +862,6 @@ public void SetBasePathCalledMultipleTimesForEachSourceLastOneWins()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void GetDefaultBasePathForSources()
{
var builder = new ConfigurationBuilder();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public void ResolveReferencePathsAcceptsCustomResolvers()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/60583", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void ResolveReferencePathsAcceptsNullCustomResolvers()
{
var library = TestLibraryFactory.Create();
Expand Down
Loading