Exclude noisy crypto rules from the repo's CodeQL runs#125364
Merged
GrabYourPitchforks merged 3 commits intomainfrom Mar 14, 2026
Merged
Exclude noisy crypto rules from the repo's CodeQL runs#125364GrabYourPitchforks merged 3 commits intomainfrom
GrabYourPitchforks merged 3 commits intomainfrom
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CodeQL configuration to reduce noise from crypto-related CodeQL queries when analyzing the repo’s own cryptography implementations and interop layers, while preserving alerts for crypto consumers elsewhere in the repo.
Changes:
- Adds query exclusions for several crypto-related CodeQL rules when scanning specific cryptography implementation/interop paths.
- Documents the rationale for excluding these rules in implementation code while keeping them enabled for consumer code.
You can also share your feedback on Copilot code review. Take the survey.
This was referenced Mar 10, 2026
bartonjs
approved these changes
Mar 10, 2026
bartonjs
approved these changes
Mar 10, 2026
jeffhandley
approved these changes
Mar 10, 2026
Member
Author
|
/ba-g deadletter - no code or build changes within this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want crypto-related CodeQL rules running over the crypto code itself. Those rules are meant for consumers of crypto and are not appropriate to run over crypto implementations or interop code. We scope the exclusions so that crypto consumers still receive alerts.