[Async v2] Implement async method variant handling in AddMethod and UpdateMethod by tommcdon · Pull Request #125397 · dotnet/runtime

Commits on Apr 16, 2026

Implement async method variant handling in AddMethod and UpdateMethod
tommcdon
committed
Use async variant in EditAndContinueModule::UpdateMethod
tommcdon
committed
Address PR feedback

tommcdon
and
Copilot
committed
EnC: Create async variant for generic instantiations in AddMethod

tommcdon
and
Copilot
committed
Address PR #125397 feedback: GC comment, infrastructure async rejection, generic UpdateMethod comment

tommcdon
and
Copilot
committed
Remove dead store taskTokenOffsetFromAsyncDetailsOffset in BuildAsyncVariantSignature

tommcdon
and
Copilot
committed
Address noahfalk feedback: clarify GC comment, reject all infrastructure async in EnC

tommcdon
and
Copilot
committed
Address jkotas/copilot feedback: fix GC comment, use CORDBG_E_ENC_EDIT_NOT_SUPPORTED

tommcdon
and
Copilot
committed
Fix cross-allocator async variant signature for generic instantiations

tommcdon
and
Copilot
committed
Replace Unicode arrows with ASCII in C++ comments

tommcdon
and
Copilot
committed
Revert per-instantiation signature allocation per jkotas feedback

tommcdon
and
Copilot
committed
EnC: Create async variant MethodDescs lazily on first use

tommcdon
and
Copilot
committed
Use VolatileStore in AddChunk for ARM64 store ordering

tommcdon
and
Copilot
committed
Address review feedback: narrow GC violation scope, fix redundant reset

tommcdon
and
Copilot
committed
Fix misleading comment: classification is for async variants, not GC avoidance

tommcdon
and
Copilot
committed
Remove redundant async variant reset in UpdateMethod

tommcdon
and
Copilot
committed
Simplify async classification in AddMethod

tommcdon
and
Copilot
committed
Address PR review feedback: defensive checks and VolatileLoad pairing

tommcdon
and
Copilot
committed
Update GC safety comment to acknowledge Won't Fix corner case

tommcdon
and
Copilot
committed
Simplify FCAMD lazy creation check and update GC comment

tommcdon
and
Copilot
committed

Commits on Apr 17, 2026

Commits on Apr 20, 2026

Create EnC async variant MethodDescs eagerly in AddMethod

tommcdon
and
Copilot
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Async v2] Implement async method variant handling in AddMethod and UpdateMethod#125397

[Async v2] Implement async method variant handling in AddMethod and UpdateMethod#125397
tommcdon merged 29 commits intodotnet:mainfrom
tommcdon:dev/tommcdon/implement_addmethoddesc

Commits on Apr 16, 2026

Implement async method variant handling in AddMethod and UpdateMethod

Use async variant in EditAndContinueModule::UpdateMethod

Address PR feedback

EnC: Create async variant for generic instantiations in AddMethod

Address PR #125397 feedback: GC comment, infrastructure async rejection, generic UpdateMethod comment

Remove dead store taskTokenOffsetFromAsyncDetailsOffset in BuildAsyncVariantSignature

Address noahfalk feedback: clarify GC comment, reject all infrastructure async in EnC

Address jkotas/copilot feedback: fix GC comment, use CORDBG_E_ENC_EDIT_NOT_SUPPORTED

Fix cross-allocator async variant signature for generic instantiations

Replace Unicode arrows with ASCII in C++ comments

Revert per-instantiation signature allocation per jkotas feedback

EnC: Create async variant MethodDescs lazily on first use

Use VolatileStore in AddChunk for ARM64 store ordering

Address review feedback: narrow GC violation scope, fix redundant reset

Fix misleading comment: classification is for async variants, not GC avoidance

Remove redundant async variant reset in UpdateMethod

Simplify async classification in AddMethod

Address PR review feedback: defensive checks and VolatileLoad pairing

Update GC safety comment to acknowledge Won't Fix corner case

Simplify FCAMD lazy creation check and update GC comment

Commits on Apr 17, 2026

Fix rebase against Vlad's async variant API renames

Revert cosmetic declaration move; keep InitMethodDesc comment clarification

Commits on Apr 20, 2026

Create EnC async variant MethodDescs eagerly in AddMethod

Commits on Apr 21, 2026

Create async variant MethodDescs for all task-returning methods in EnC

De-duplicate async variant signature construction

Switch to user-code MethodDesc for EnC remap breakpoints

Commits on Apr 23, 2026

Inline async variant sig construction and revert shared function

Return early from UpdateFunction when async variant is missing

Re-document known corner-case GC violation in AddMethod