Skip to content

[release/9.0] fix xharness #125462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoyosjs merged 1 commit into from
Mar 11, 2026
Merged

[release/9.0] fix xharness #125462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@
return Task.CompletedTask;
}

public override string WriteResultsToFile(XmlResultJargon xmlResultJargon)
public override Task<string> WriteResultsToFile(XmlResultJargon xmlResultJargon)

Check failure on line 53 in src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release AllSubsets_Mono_RuntimeTests monointerpreter)

src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs#L53 

src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs(53,34): error CS0508: 'GeneratedTestRunner.WriteResultsToFile(XmlResultJargon)': return type must be 'string' to match overridden member 'TestRunner.WriteResultsToFile(XmlResultJargon)' [/__w/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj]

Check failure on line 53 in src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs

View check run for this annotation

Azure Pipelines / runtime

src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs#L53 

src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs(53,34): error CS0508: 'GeneratedTestRunner.WriteResultsToFile(XmlResultJargon)': return type must be 'string' to match overridden member 'TestRunner.WriteResultsToFile(XmlResultJargon)' [/__w/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj]
{
Debug.Assert(xmlResultJargon == XmlResultJargon.xUnit);
File.WriteAllText(ResultsFileName, LastTestRun.GetTestResultOutput(_assemblyName));
return ResultsFileName;
return Task.FromResult(ResultsFileName);
}

public override void WriteResultsToFile(TextWriter writer, XmlResultJargon jargon)
public override Task WriteResultsToFile(TextWriter writer, XmlResultJargon jargon)

Check failure on line 60 in src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release AllSubsets_Mono_RuntimeTests monointerpreter)

src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs#L60 

src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs(60,26): error CS0508: 'GeneratedTestRunner.WriteResultsToFile(TextWriter, XmlResultJargon)': return type must be 'void' to match overridden member 'TestRunner.WriteResultsToFile(TextWriter, XmlResultJargon)' [/__w/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj]

Check failure on line 60 in src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs

View check run for this annotation

Azure Pipelines / runtime

src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs#L60 

src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs(60,26): error CS0508: 'GeneratedTestRunner.WriteResultsToFile(TextWriter, XmlResultJargon)': return type must be 'void' to match overridden member 'TestRunner.WriteResultsToFile(TextWriter, XmlResultJargon)' [/__w/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj]
{
Debug.Assert(jargon == XmlResultJargon.xUnit);
string lastTestResults = LastTestRun.GetTestResultOutput(_assemblyName);
Expand All @@ -71,6 +71,7 @@
{
writer.WriteLine(lastTestResults);
}
return Task.CompletedTask;
}

public override void SkipTests(IEnumerable<string> tests)
Expand Down
Loading