Draft
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @SamMonoRT, @dotnet/efteam |
stephentoub
reviewed
Mar 12, 2026
src/libraries/System.Data.Common/src/System/Data/Common/DataRecordInternal.cs
Outdated
Show resolved
Hide resolved
added 2 commits
March 12, 2026 20:03
Used a (ulong) cast to simultaneously check for negative values and values greater than int.MaxValue. This prevents potential out-of-bounds reads with negative indices like Int64.MinValue while preserving the original exception type.
This was referenced Mar 13, 2026
src/libraries/System.Data.Common/src/System/Data/Common/DataRecordInternal.cs
Show resolved
Hide resolved
src/libraries/System.Data.Common/src/System/Data/Common/DataRecordInternal.cs
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes integer overflow when dataIndex is a large negative long value by casting to ulong before comparison, ensuring negative values are caught.
Changes:
- Cast
dataIndextoulongbefore comparing toint.MaxValueinGetBytesandGetChars - Added tests for
Int64.MinValueasdataIndex
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DataRecordInternal.cs | Cast dataIndex to ulong to catch negative values |
| DataRecordInternalTest.cs | Tests for negative dataIndex overflow scenario |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
Author
|
Should i push this changes to other branches (release/*)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
dataIndexis less than-2147483648,InvalidSourceBufferIndexwill not be thrown. In this case,int ndataIndex = (int)dataIndex;assignsndataIndexthe truncated value ofdataIndex.Found by Linux Verification Center (linuxtesting.org) with SVACE.