Skip to content

Improve UnwindInfoTable's performance #125545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eduardo-vp merged 24 commits into from
Mar 20, 2026
+221 −127
Merged

Improve UnwindInfoTable's performance #125545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7358ca6
Batch unwind info table entries
Mar 17, 2026
23fc617
Flush before method is done JITing
Mar 17, 2026
2d1341c
Use two locks
Mar 17, 2026
ed61200
Copilot code review
Mar 18, 2026
58cbb75
Revert "Copilot code review"
Mar 18, 2026
00c8e3d
Read the table under the publish lock for early return
Mar 18, 2026
fc63e44
Check for null hHandle in FlushPendingEntries
Mar 18, 2026
e94cfd3
PR feedback
Mar 18, 2026
d0fa5bc
Update commet
eduardo-vp Mar 18, 2026
2aaa476
PR feedback
Mar 18, 2026
543d15e
Perf: remove unwind info handle null check
Mar 18, 2026
50c7708
Potential fix for pull request finding
eduardo-vp Mar 19, 2026
2f63685
Make AddToUnwindInfoTable an instance method
Mar 19, 2026
28dd859
Add as many entries as possible after taking the pending lock
Mar 19, 2026
526beac
Delete old table outside of the lock
Mar 19, 2026
fbe8eb6
Flush after adding all the entries
eduardo-vp Mar 19, 2026
a65988f
Remove flush at the end of publish method
eduardo-vp Mar 19, 2026
f0560fd
Some PR feedback
Mar 19, 2026
9db1f73
Remove unnecessary check of the pending buffer when removing unwind info
Mar 19, 2026
8a82cf5
Take publish lock at the beginning of FlushPendingEntries
Mar 20, 2026
d41ee90
Free the old table outside the lock
eduardo-vp Mar 20, 2026
ee97980
PR feedback
eduardo-vp Mar 20, 2026
fd3cfaa
Update comment
Mar 20, 2026
84a197a
Nits
Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/coreclr/inc/CrstTypes.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,13 @@ Crst SingleUseLock
AcquiredBefore LoaderHeap UniqueStack DebuggerJitInfo
End

Crst UnwindInfoTableLock
Crst UnwindInfoTablePublishLock
AcquiredAfter SingleUseLock
AcquiredBefore UnwindInfoTablePendingLock
End

Crst UnwindInfoTablePendingLock
AcquiredAfter UnwindInfoTablePublishLock
AcquiredBefore StressLog
End

Expand Down
15 changes: 9 additions & 6 deletions src/coreclr/inc/crsttypes_generated.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,11 @@ enum CrstType
CrstUMEntryThunkFreeListLock = 98,
CrstUniqueStack = 99,
CrstUnresolvedClassLock = 100,
CrstUnwindInfoTableLock = 101,
CrstVSDIndirectionCellLock = 102,
CrstWrapperTemplate = 103,
kNumberOfCrstTypes = 104
CrstUnwindInfoTablePendingLock = 101,
CrstUnwindInfoTablePublishLock = 102,
CrstVSDIndirectionCellLock = 103,
CrstWrapperTemplate = 104,
kNumberOfCrstTypes = 105
};

#endif // __CRST_TYPES_INCLUDED
Expand Down Expand Up @@ -231,7 +232,8 @@ int g_rgCrstLevelMap[] =
2, // CrstUMEntryThunkFreeListLock
3, // CrstUniqueStack
6, // CrstUnresolvedClassLock
2, // CrstUnwindInfoTableLock
2, // CrstUnwindInfoTablePendingLock
3, // CrstUnwindInfoTablePublishLock
3, // CrstVSDIndirectionCellLock
2, // CrstWrapperTemplate
};
Expand Down Expand Up @@ -340,7 +342,8 @@ LPCSTR g_rgCrstNameMap[] =
"CrstUMEntryThunkFreeListLock",
"CrstUniqueStack",
"CrstUnresolvedClassLock",
"CrstUnwindInfoTableLock",
"CrstUnwindInfoTablePendingLock",
"CrstUnwindInfoTablePublishLock",
"CrstVSDIndirectionCellLock",
"CrstWrapperTemplate",
};
Expand Down
Loading
Loading