-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fix IndexOutOfRangeException in FrozenHashTable when creating from huge collections #125555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
edd03fb
9038f2b
86ab3ea
339f322
6a9eeae
0468f26
12687c0
e169e7e
9c19e4b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -434,6 +434,14 @@ protected override ulong CreateT(int seed) | |
| ulong lo = unchecked((ulong)rand.Next()); | ||
| return (hi << 32) | lo; | ||
| } | ||
|
|
||
| [OuterLoop("Takes several seconds")] | ||
| [Theory] | ||
| [InlineData(8_000_000)] | ||
| public void CreateHugeSet_Success(int largeCount) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dictionary one has AllowVeryLargeSizes. Set doesn't have that variable, but it's redundant anyway as in neither case is the fixture subclassed, and the purpose of this I guess is to limit executions of slow tests.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these comments are by Dan. |
||
| { | ||
| GenericISetFactory(largeCount); | ||
| } | ||
| } | ||
|
|
||
| public class FrozenSet_Generic_Tests_int : FrozenSet_Generic_Tests<int> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.