Fix inner build of community archs#125653
Merged
janvorli merged 2 commits intodotnet:mainfrom Mar 20, 2026
Merged
Conversation
The full build (./build.sh) is working because it goes through MSBuild
(runtime.proj) which has explicit top-level defaults setting
`FEATURE_DYNAMIC_CODE_COMPILED=1` for all architectures. This enables
Virtual Stub Dispatch (VSD) + dynamic code generation, and
riscv64/loongarch64 both have complete VSD implementations in
`runtime/{arch}/StubDispatch.S`.
The inner build (src/coreclr/build-runtime.sh) was failing because it
invoked CMake directly without the top-level context. The CMake feature
logic in clrfeatures.cmake had no architecture-specific defaults, so it
defaulted to `FEATURE_DYNAMIC_CODE_COMPILED=0` for riscv64/loongarch64.
This triggered a configuration requiring both
`StubPrecodeDynamicHelpers.S` and `CachedInterfaceDispatchCoreCLR.S`
assembly stubs—neither of which were implemented for those
architectures—causing undefined symbol linker errors. The CMake fix now
forces `FEATURE_DYNAMIC_CODE_COMPILED=1` for both architectures in
`clrfeatures.cmake``, aligning the inner build with the top-level
defaults.
dotnet-policy-service
bot
added
the
community-contribution
am11
added
area-Infrastructure-coreclr
arch-loongarch64
arch-riscv
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
Member
Author
|
@janvorli, thanks. Could you please merge this as well? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full build (./build.sh) is working because it goes through MSBuild (runtime.proj) which has explicit top-level defaults setting
FEATURE_DYNAMIC_CODE_COMPILED=1for all architectures. This enables Virtual Stub Dispatch (VSD) + dynamic code generation, and riscv64/loongarch64 both have complete VSD implementations inruntime/{arch}/StubDispatch.S.The inner build (src/coreclr/build-runtime.sh) was failing because it invoked CMake directly without the top-level context. The CMake feature logic in clrfeatures.cmake had no architecture-specific defaults, so it defaulted to
FEATURE_DYNAMIC_CODE_COMPILED=0for riscv64/loongarch64. This triggered a configuration requiring bothStubPrecodeDynamicHelpers.SandCachedInterfaceDispatchCoreCLR.Sassembly stubs—neither of which were implemented for those architectures—causing undefined symbol linker errors. The CMake fix now forcesFEATURE_DYNAMIC_CODE_COMPILED=1for both architectures in `clrfeatures.cmake``, aligning the inner build with the top-level defaults.Fixes #125642