[runtime tests] Make 2 tests conditional on MT enabled#125658
[runtime tests] Make 2 tests conditional on MT enabled#125658radekdoulik merged 3 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
Updates two JIT regression tests to only run when the runtime supports multithreading, avoiding failures/hangs on single-threaded targets.
Changes:
- Switch
b72218from[Fact]to[ConditionalFact(...IsMultithreadingSupported)]. - Switch
SyncGCHolefrom[Fact]to[ConditionalFact(...IsMultithreadingSupported)].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tests/JIT/Regression/CLR-x86-JIT/v2.1/b72218/b72218.cs | Makes the test conditional on multithreading support. |
| src/tests/JIT/Regression/CLR-x86-JIT/V1.2-M01/b08046cs/SyncGCHole.cs | Makes the test conditional on multithreading support. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates a pair of JIT regression tests to be skipped on platforms/runtimes where multithreading isn’t supported, avoiding failures due to Thread usage in single-threaded environments.
Changes:
- Add
using TestLibrary;to accessPlatformDetection. - Replace
[Fact]with[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))]on two tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tests/JIT/Regression/CLR-x86-JIT/v2.1/b72218/b72218.cs | Makes the test conditional on multithreading support via PlatformDetection. |
| src/tests/JIT/Regression/CLR-x86-JIT/V1.2-M01/b08046cs/SyncGCHole.cs | Makes the test conditional on multithreading support via PlatformDetection. |
src/tests/JIT/Regression/CLR-x86-JIT/V1.2-M01/b08046cs/SyncGCHole.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates two legacy JIT regression tests that create threads so they only run when multithreading is supported (e.g., skipping single-threaded WASM/WASI environments).
Changes:
- Replace
[Fact]with[ConditionalFact(...IsMultithreadingSupported)]on two tests that createThreads. - Add
using TestLibrary;to accessPlatformDetection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/JIT/Regression/CLR-x86-JIT/v2.1/b72218/b72218.cs | Makes the test conditional on PlatformDetection.IsMultithreadingSupported. |
| src/tests/JIT/Regression/CLR-x86-JIT/V1.2-M01/b08046cs/SyncGCHole.cs | Makes the test conditional on PlatformDetection.IsMultithreadingSupported. |
No description provided.