Try checking for Darwin and Clang in addition to AppleClang#125758
Closed
jtschuster wants to merge 1 commit intodotnet:mainfrom
Closed
Try checking for Darwin and Clang in addition to AppleClang#125758jtschuster wants to merge 1 commit intodotnet:mainfrom
jtschuster wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the native CMake compiler configuration to make the $<LINK_GROUP:RESCAN> no-op workaround less dependent on AppleClang detection, improving resiliency on Darwin build machines whose toolchains may report Clang instead.
Changes:
- Extend the
$<LINK_GROUP:RESCAN>no-op enablement to also apply whenCMAKE_SYSTEM_NAME == "Darwin"andCMAKE_CXX_COMPILER_ID == "Clang". - Keep the existing AppleClang-specific logic for forcing the classic linker on Xcode 15.
- Minor whitespace cleanup in the Emscripten version mismatch warning block.
Member
Where did the non-standard (?) clang version that got installed on the build machines come from? |
Member
|
The new osx-x64 build failure is #104105 |
This was referenced Mar 19, 2026
Open
Member
|
Superseded by #125763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build machines may have had some changes that cause this workaround to be more fragile. Try checkign for
CMAKE_SYSTEM_NAME == "Darwin" AND CMAKE_CXX_COMPILER_ID == "Clang"in addition toCMAKE_CXX_COMPILER_ID == "AppleClang"