Skip to content

Increase TTL in SendPingWithLowTtl_RoundtripTimeIsNonZero to fix macOS flakiness #125774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rzikm wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Increase TTL in SendPingWithLowTtl_RoundtripTimeIsNonZero to fix macOS flakiness #125774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,10 @@ public async Task SendPingWithLowTtl_RoundtripTimeIsNonZero()

// RTT can legitimately be 0ms on very fast networks, so retry a few times
// and assert that at least one reply reports a non-zero RTT.
options.Ttl = 1;
// Use TTL=5 instead of 1 to increase the chance of a measurable (>0ms) round-trip
// time. On macOS, the raw socket implementation truncates sub-millisecond RTT to 0,
// and the first-hop router often responds in <1ms.
options.Ttl = 5;
bool gotNonZeroRtt = false;
for (int attempt = 0; attempt < 3; attempt++)
{
Expand Down
Loading