Revert "[release/8.0] Remove Homebrew LLVM during macOS CI setup"#125787
Closed
rbhanda wants to merge 1 commit intorelease/8.0from
Closed
Revert "[release/8.0] Remove Homebrew LLVM during macOS CI setup"#125787rbhanda wants to merge 1 commit intorelease/8.0from
rbhanda wants to merge 1 commit intorelease/8.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the earlier change that removed Homebrew LLVM during macOS CI dependency setup, restoring the prior behavior of leaving any preinstalled Homebrew LLVM on the runner.
Changes:
- Removed the
brew uninstall --ignore-dependencies llvmstep from the macOS/iOS/tvOS dependency installation path. - Removed the associated explanatory comment block describing why Homebrew LLVM was being uninstalled.
You can also share your feedback on Copilot code review. Take the survey.
| # The build uses Apple clang from /usr/bin/clang exclusively. | ||
| brew uninstall --ignore-dependencies llvm 2>/dev/null || true | ||
|
|
||
| brew bundle --no-upgrade --file "$(dirname "$0")/Brewfile" |
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #125783