Skip to content

Add retry for StackTraceTests.ToString_ShowILOffset AMSI hang #125814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 3 commits into from
Mar 20, 2026
Merged

Add retry for StackTraceTests.ToString_ShowILOffset AMSI hang #125814

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
761f904
Split Assembly.Load(byte[]) test case and add retry for AMSI hang
danmoseley Mar 20, 2026
28fda3e
Address PR feedback: limit retry to Windows timeout only
danmoseley Mar 20, 2026
2caaf3f
Scope AMSI retry to Windows x86 only
danmoseley Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 38 additions & 18 deletions src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using System.Reflection;
using System.Reflection.Emit;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Text.RegularExpressions;
using Microsoft.DotNet.RemoteExecutor;
using System.Threading.Tasks;
Expand Down Expand Up @@ -541,24 +542,7 @@ public void ToString_ShowILOffset()
}
}, SourceTestAssemblyPath, AssemblyName, regPattern).Dispose();

// Assembly.Load(Byte[]) case
RemoteExecutor.Invoke((asmPath, asmName, p) =>
{
AppContext.SetSwitch("Switch.System.Diagnostics.StackTrace.ShowILOffsets", true);
var inMemBlob = File.ReadAllBytes(asmPath);
var asm2 = Assembly.Load(inMemBlob);
try
{
asm2.GetType("Program").GetMethod("Foo").Invoke(null, null);
}
catch (Exception e)
{
Assert.Contains(asmName, e.InnerException.StackTrace);
Assert.Matches(p, e.InnerException.StackTrace);
}
}, SourceTestAssemblyPath, AssemblyName, regPattern).Dispose();

// AssmblyBuilder.DefineDynamicAssembly() case
// AssemblyBuilder.DefineDynamicAssembly() case
RemoteExecutor.Invoke((p) =>
{
AppContext.SetSwitch("Switch.System.Diagnostics.StackTrace.ShowILOffsets", true);
Expand All @@ -583,6 +567,42 @@ public void ToString_ShowILOffset()
}, regPattern).Dispose();
}

// Assembly.Load(byte[]) triggers an AMSI (Antimalware Scan Interface) scan via Windows Defender.
// On some Windows x86 CI machines the AMSI RPC call hangs indefinitely,
// so we retry with a shorter timeout to work around the transient OS issue.
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public void ToString_ShowILOffset_ByteArrayLoad()
{
string AssemblyName = "ExceptionTestAssembly.dll";
string SourceTestAssemblyPath = Path.Combine(Environment.CurrentDirectory, AssemblyName);
string regPattern = @":token 0x([a-f0-9]*)\+0x([a-f0-9]*)";

const int maxAttempts = 3;
for (int attempt = 1; ; attempt++)
{
try
{
var options = new RemoteInvokeOptions { TimeOut = 30_000 };
RemoteExecutor.Invoke((asmPath, asmName, p) =>
{
AppContext.SetSwitch("Switch.System.Diagnostics.StackTrace.ShowILOffsets", true);
var inMemBlob = File.ReadAllBytes(asmPath);
var asm = Assembly.Load(inMemBlob);
TargetInvocationException ex = Assert.Throws<TargetInvocationException>(
() => asm.GetType("Program").GetMethod("Foo").Invoke(null, null));
Assert.Contains(asmName, ex.InnerException.StackTrace);
Assert.Matches(p, ex.InnerException.StackTrace);
}, SourceTestAssemblyPath, AssemblyName, regPattern, options).Dispose();
break;
}
catch (RemoteExecutionException ex) when (OperatingSystem.IsWindows() && RuntimeInformation.ProcessArchitecture == Architecture.X86 && attempt < maxAttempts && ex.Message.Contains("Timed out"))
{
// AMSI hang: on some Windows x86 CI machines, Assembly.Load(byte[]) triggers an AMSI scan
// whose RPC call hangs indefinitely. Retry with a fresh process.
}
}
}

// On Android, stack traces do not include file names and line numbers
// Tracking issue: https://github.com/dotnet/runtime/issues/124087
private static string FileInfoPattern(string fileLinePattern) =>
Expand Down
Loading