JIT: Remove dead Vector2/3 lowering code#125821
Open
saucecontrol wants to merge 3 commits intodotnet:mainfrom
Open
JIT: Remove dead Vector2/3 lowering code#125821saucecontrol wants to merge 3 commits intodotnet:mainfrom
saucecontrol wants to merge 3 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes lowering/codegen special-cases for 8/12-byte SIMD shapes (Vector2/Vector3) in JIT HWIntrinsic paths, based on the premise that these shapes are no longer produced now that the relevant SIMD types are implemented via HWIntrinsics.
Changes:
- Simplify
LowerHWIntrinsicCmpOpandLowerHWIntrinsicDotby removing SIMD8/SIMD12-specific logic and tightening associated assertions. - Tighten constant-create assertions to exclude SIMD8/SIMD12 where those sizes are no longer expected.
- Use
ToScalarinstead ofGetElement(0)for ARM64 Dot result extraction.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/coreclr/jit/lowerxarch.cpp |
Removes SIMD8/SIMD12 handling in compare/dot lowering and tightens create assertions. |
src/coreclr/jit/lowerarmarch.cpp |
Removes SIMD12-specific compare/dot handling and tightens create assertions; updates comment to Vector64/128. |
src/coreclr/jit/hwintrinsicarm64.cpp |
Changes Dot scalar extraction to use gtNewSimdToScalarNode. |
src/coreclr/jit/gentree.cpp |
Tightens comparison intrinsic size assertion (drops SIMD12). |
This was referenced Mar 20, 2026
Member
Author
|
cc @dotnet/jit-contrib This is zero diff for aarch, small improvement for xarch due to removal of the containment check bailout for SIMD8 and SIMD12 (these are handled correctly now that all HWIntrinsic containment logic uses operand size). |
This was referenced Mar 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the old SIMD types now use HWIntrinsics, these paths are dead.