Stabilize ML-DSA X.509 PKIs with published RFC 9881.#125834
Open
vcsjones wants to merge 1 commit intodotnet:mainfrom
Open
Stabilize ML-DSA X.509 PKIs with published RFC 9881.#125834vcsjones wants to merge 1 commit intodotnet:mainfrom
vcsjones wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes ML-DSA-related X.509 APIs by removing ExperimentalAttribute from the ML-DSA PKI surface area (PublicKey, X509Certificate2, certificate key accessor extensions, and ML-DSA SPKI/PKCS#8 import/export), aligning with the publication of RFC 9881. External-Mu and SignPreHash ML-DSA APIs remain experimental.
Changes:
- Removed
ExperimentalAttributefrom ML-DSA members onPublicKey,X509Certificate2, andX509CertificateKeyAccessors. - Removed
ExperimentalAttributefrom ML-DSA SPKI and PKCS#8 import/export APIs (including encrypted PKCS#8 and PEM helpers) and updated reference assemblies accordingly. - Updated compatibility/apicompat suppression baselines and refreshed IETF test/vector references to RFC 9881.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs | Removes experimental markings from ML-DSA certificate key APIs. |
| src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/PublicKey.cs | Removes experimental markings from ML-DSA PublicKey ctor and key extraction API. |
| src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs | Updates public ref surface to reflect ML-DSA stabilization (SPKI/PKCS#8 + X509 APIs). |
| src/libraries/Microsoft.Bcl.Cryptography/src/System/Security/Cryptography/X509Certificates/X509CertificateKeyAccessors.cs | Removes experimental markings from ML-DSA extension APIs. |
| src/libraries/Microsoft.Bcl.Cryptography/src/CompatibilitySuppressions.xml | Adds package-validation suppressions for experimental-attribute deltas related to stabilization. |
| src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaTestsData.Ietf.cs | Updates test-data source link to RFC 9881. |
| src/libraries/Common/src/System/Security/Cryptography/MLDsa.cs | Removes experimental markings from ML-DSA SPKI/PKCS#8 import/export APIs. |
| src/libraries/Common/src/System/Security/Cryptography/Asn1/MLDsaPrivateKeyBothAsn.xml | Updates RFC reference and documents expanded key sizing for multiple parameter sets. |
| src/libraries/Common/src/System/Security/Cryptography/Asn1/MLDsaPrivateKeyAsn.xml | Updates RFC reference URL. |
| src/libraries/apicompat/ApiCompatBaseline.NetCoreAppLatestStable.xml | Adds apicompat suppressions for experimental-attribute removals between net10 and net11. |
src/libraries/Common/src/System/Security/Cryptography/Asn1/MLDsaPrivateKeyBothAsn.xml
Show resolved
Hide resolved
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
ExperimentalAttributeon:PublicKeyMLDsamembers.X509Certificate2MLDsamembers.X509CertificateKeyAccessorsMLDsamembers.MLDsa.External-Mu and SignPreHash members on
MLDsaremainExperimental.Closes #125751