Skip to content

Fix flaky Linux process name tests by polling after Process.Start #125918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 7 commits into from
Mar 26, 2026
Merged

Fix flaky Linux process name tests by polling after Process.Start #125918

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a13615
Initial plan
Copilot Mar 22, 2026
6531bc2
Fix fork/exec race in GetUntruncatedProcessName by using /proc/pid/ex…
Copilot Mar 22, 2026
98ed1dd
Clarify GetExeBasenameOrComm comment: race is fully eliminated on gli…
Copilot Mar 23, 2026
cfb29b0
Apply style nit: use pattern matching in GetExeBasenameOrComm
Copilot Mar 23, 2026
583db8e
Fix flaky tests by polling ProcessName instead of patching production…
Copilot Mar 24, 2026
e012dae
Merge branch 'main' into copilot/fix-test-expecting-sleep
danmoseley Mar 25, 2026
a6324ca
Simplify polling loop to use RetryHelper; fix comment to say thread name
danmoseley Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,13 @@ public void ProcessStart_OnLinux_UsesSpecifiedProgram()
{
try
{
Assert.Equal(Program, px.ProcessName);
// ProcessName may transiently reflect the parent's thread name immediately
// after fork() if execve() hasn't completed yet in the child, so retry briefly.
RetryHelper.Execute(() =>
{
px.Refresh();
Assert.Equal(Program, px.ProcessName);
});
}
finally
{
Expand All @@ -374,7 +380,13 @@ public void ProcessStart_OnLinux_UsesSpecifiedProgramUsingArgumentList()
{
try
{
Assert.Equal(Program, px.ProcessName);
// ProcessName may transiently reflect the parent's thread name immediately
// after fork() if execve() hasn't completed yet in the child, so retry briefly.
RetryHelper.Execute(() =>
{
px.Refresh();
Assert.Equal(Program, px.ProcessName);
});
}
finally
{
Expand Down
Loading