Skip to content

Fix flaky signal handler test on mono on Linux #125969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrek-msft merged 2 commits into from
Mar 24, 2026
Merged

Fix flaky signal handler test on mono on Linux #125969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e2aede
Fix flaky test caused by non-empty stdout check when remote process i…
mrek-msft Mar 23, 2026
a3c4d90
Rework to do not send two signal in Mono case.
mrek-msft Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,16 +248,21 @@ public void SignalHandler_CanDisposeInHandler(PosixSignal signal)
AssertRemoteProcessStandardOutputLine(remoteHandle, PosixSignalHandlerStartedMessage, WaitInMS);
AssertRemoteProcessStandardOutputLine(remoteHandle, PosixSignalHandlerDisposedMessage, WaitInMS);

SendSignal(signal, remoteHandle.Process.Id);

// https://github.com/dotnet/runtime/issues/125733
Comment thread
mrek-msft marked this conversation as resolved.
// Mono prints running threads stack trace listings and does not quit on receiving SIGQUIT
if (PlatformDetection.IsMonoRuntime && signal == PosixSignal.SIGQUIT && !PlatformDetection.IsWindows)
Comment thread
mrek-msft marked this conversation as resolved.
{
// Terminate process using SIGTERM instead.
SendSignal(PosixSignal.SIGTERM, remoteHandle.Process.Id);
}
else
{
SendSignal(signal, remoteHandle.Process.Id);
}

Assert.True(remoteHandle.Process.WaitForExit(WaitInMS));
Assert.True(remoteHandle.Process.StandardOutput.EndOfStream);

if (OperatingSystem.IsWindows())
{
Assert.Equal(unchecked((int)0xC000013A), remoteHandle.Process.ExitCode); // STATUS_CONTROL_C_EXIT
Expand Down
Loading