-
Notifications
You must be signed in to change notification settings - Fork 5.4k
IL Trim attributes with a feature flag in all assemblies #126094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
...s/System.Runtime/tests/System.Runtime.Tests/TrimmingTests/MetadataUpdateHandlerTrimmed.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Reflection; | ||
| using System.Reflection.Metadata; | ||
|
pavelsavara marked this conversation as resolved.
|
||
|
|
||
| /// <summary> | ||
| /// Tests that when MetadataUpdater.IsSupported is false, the MetadataUpdateHandlerAttribute | ||
| /// instances and the handler types they reference are trimmed from all assemblies. | ||
|
pavelsavara marked this conversation as resolved.
|
||
| /// </summary> | ||
| class Program | ||
| { | ||
| static int Main(string[] args) | ||
| { | ||
| // Hard references to ensure these assemblies are loaded and not entirely removed by the trimmer. | ||
| // We use types that the trimmer cannot remove (public API surface). | ||
| _ = typeof(System.ComponentModel.TypeConverter); | ||
| _ = typeof(System.Text.Json.JsonSerializer); | ||
|
|
||
| // MetadataUpdater.IsSupported should be false | ||
| if (MetadataUpdater.IsSupported) | ||
| { | ||
| Console.WriteLine("Failed: MetadataUpdater.IsSupported should be false"); | ||
| return -1; | ||
| } | ||
|
|
||
| // Verify MetadataUpdateHandlerAttribute is not present on any assembly | ||
| foreach (var assembly in AppDomain.CurrentDomain.GetAssemblies()) | ||
| { | ||
| foreach (var attr in assembly.GetCustomAttributesData()) | ||
| { | ||
| if (attr.AttributeType.Name == "MetadataUpdateHandlerAttribute") | ||
|
pavelsavara marked this conversation as resolved.
|
||
| { | ||
| Console.WriteLine($"Failed: {assembly.GetName().Name} still has MetadataUpdateHandlerAttribute"); | ||
| return -1; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Verify the handler types themselves are trimmed | ||
| string[] handlerTypeNames = new[] | ||
| { | ||
| "System.Reflection.Metadata.RuntimeTypeMetadataUpdateHandler", | ||
| "System.ComponentModel.ReflectionCachesUpdateHandler", | ||
| "System.Text.Json.JsonSerializerOptionsUpdateHandler", | ||
| }; | ||
|
|
||
| foreach (var assembly in AppDomain.CurrentDomain.GetAssemblies()) | ||
| { | ||
| foreach (var typeName in handlerTypeNames) | ||
| { | ||
| var type = assembly.GetType(typeName); | ||
| if (type != null) | ||
| { | ||
| Console.WriteLine($"Failed: {assembly.GetName().Name} still contains {typeName}"); | ||
| return -1; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return 100; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect
<assembly fullname="System.Private.CoreLib"to be defining identify of the attribute, so*does not make sense.