Skip to content

Bump picomatch in /src/native#126131

Merged
danmoseley merged 3 commits intomainfrom
dependabot/npm_and_yarn/src/native/multi-bf05dc1ecf
Apr 15, 2026
Merged

Bump picomatch in /src/native#126131
danmoseley merged 3 commits intomainfrom
dependabot/npm_and_yarn/src/native/multi-bf05dc1ecf

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Mar 25, 2026

Bumps and picomatch. These dependencies needed to be updated together.
Updates picomatch from 4.0.3 to 4.0.4

Release notes

Sourced from picomatch's releases.

4.0.4

This is a security release fixing several security relevant issues.

What's Changed

Full Changelog: micromatch/picomatch@4.0.3...4.0.4

Commits

Updates picomatch from 2.3.1 to 2.3.2

Release notes

Sourced from picomatch's releases.

4.0.4

This is a security release fixing several security relevant issues.

What's Changed

Full Changelog: micromatch/picomatch@4.0.3...4.0.4

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps  and [picomatch](https://github.com/micromatch/picomatch). These dependencies needed to be updated together.

Updates `picomatch` from 4.0.3 to 4.0.4
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@4.0.3...4.0.4)

Updates `picomatch` from 2.3.1 to 2.3.2
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@4.0.3...4.0.4)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 4.0.4
  dependency-type: indirect
- dependency-name: picomatch
  dependency-version: 2.3.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions

This comment has been minimized.

@danmoseley
Copy link
Copy Markdown
Member

@agocke ok to merge?

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Copilot Code Review — PR #126131

Note

This review was generated by Copilot.

Holistic Assessment

Motivation: Justified. This Dependabot PR bumps two picomatch transitive dev dependencies to patch versions that fix CVE-2026-33671 and CVE-2026-33672 (ReDoS via nested extglob patterns). Security patches for known CVEs should be merged promptly.

Approach: Correct. Only src/native/package-lock.json is modified — no package.json change is needed because picomatch is an indirect dependency (consumed via micromatch/fast-glob in the JS build toolchain). This is the standard Dependabot approach for transitive security fixes.

Summary: ✅ LGTM. Low-risk, automated security patch affecting only dev-time JS build tooling. No .NET runtime, library, or test code is impacted.


Detailed Findings

✅ Security — CVE fixes confirmed

Both bumps address the same upstream security advisory:

  • picomatch 4.0.3 → 4.0.4
  • picomatch 2.3.1 → 2.3.2 (nested under micromatch/node_modules/)

The fixes add a maxExtglobRecursion depth limit and treat risky globs as literals, mitigating ReDoS vectors from deeply nested extglob patterns.

✅ Scope — Dev-only, zero runtime impact

Both entries are "dev": true indirect dependencies. They are used exclusively by the WASM/JS interop build toolchain (rollup, eslint, fast-glob) under src/native/. No .NET build artifacts, runtime behavior, or tests are affected.

💡 Integrity hashes use SHA-1

The updated entries use sha1- integrity hashes (vs. the sha512- hashes in the previous versions). This is because the resolved registry is the Azure DevOps mirror (pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public-npm) configured in src/native/.npmrc, which serves sha1 hashes. This is a pre-existing pattern: 52 of the 223 integrity hashes in this lock file already use sha1-, all from the same registry. Not a concern introduced by this PR, but worth noting for awareness.

Generated by Code Review · Workflow run 24429692238

Generated by Code Review for issue #126131 ·

@danmoseley danmoseley merged commit 04d9316 into main Apr 15, 2026
159 of 162 checks passed
@danmoseley danmoseley deleted the dependabot/npm_and_yarn/src/native/multi-bf05dc1ecf branch April 15, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-codeflow for labeling automated codeflow dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant