Skip to content

Reduce Mono/WASM PR pipeline jobs on library and non-mono changes #126137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidwrighton wants to merge 5 commits into
base: main
Choose a base branch
from
+33 −9
Open

Reduce Mono/WASM PR pipeline jobs on library and non-mono changes #126137

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0682b50
Reduce WASM and Mono Android PR pipeline jobs on library changes
davidwrighton Mar 25, 2026
5bbfed7
Reduce Mono MiniJIT Library Tests to linux_arm64 on library PRs
davidwrighton Mar 25, 2026
da0990f
Drop Firefox from Mono WASM full run and AOT Smoke from browser_wasm_win
davidwrighton Mar 25, 2026
f727219
Add Firefox scenario to WASM AOT Smoke tests
davidwrighton Mar 26, 2026
4c0f683
Merge branch 'main' into reduce-pr-pipeline-jobs
davidwrighton Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions eng/pipelines/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,13 +945,13 @@ extends:
extraBuildArgs: /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
scenarios:
- WasmTestOnChrome
- WasmTestOnFirefox

- template: /eng/pipelines/common/templates/wasm-library-tests.yml
parameters:
platforms:
- browser_wasm_win
alwaysRun: ${{ variables.isRollingBuild }}
shouldRunSmokeOnly: onLibrariesAndIllinkChanges
extraBuildArgs: /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
scenarios:
- WasmTestOnChrome
Expand Down Expand Up @@ -996,13 +996,15 @@ extends:
parameters:
platforms:
- browser_wasm
- browser_wasm_win
nameSuffix: _Smoke_AOT
runAOT: true
buildAOTOnHelix: false
shouldRunSmokeOnly: true
alwaysRun: ${{ variables.isRollingBuild }}
extraBuildArgs: /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
scenarios:
- WasmTestOnChrome
- WasmTestOnFirefox
Comment on lines +1005 to +1007
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AOT smoke job now explicitly adds a Firefox scenario (in addition to Chrome). Previously, the AOT smoke tests defaulted to Chrome-only via wasm-library-aot-tests.yml, so this is a behavior/work-item count change that isn’t called out in the PR description and may add extra runtime/flakiness. If the intent is only to drop browser_wasm_win while keeping the same smoke coverage, consider keeping scenarios unset (or Chrome-only) and/or updating the PR description to reflect the added Firefox run.

Copilot uses AI. Check for mistakes.

# For Wasm.Build.Tests - runtime pack builds
- template: /eng/pipelines/common/templates/wasm-build-only.yml
Expand Down Expand Up @@ -1071,8 +1073,6 @@ extends:
- android_arm64
variables:
# map dependencies variables to local variables
- name: librariesContainsChange
value: $[ stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'] ]
Comment thread
davidwrighton marked this conversation as resolved.
- name: monoContainsChange
value: $[ stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'] ]
jobParameters:
Expand All @@ -1082,9 +1082,7 @@ extends:
timeoutInMinutes: 120
condition: >-
or(
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true),
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
eq(variables['isRollingBuild'], true))
# extra steps, run tests
postBuildSteps:
Expand All @@ -1094,7 +1092,6 @@ extends:
testRunNamePrefixSuffix: Mono_$(_BuildConfig)
condition: >-
or(
eq(variables['librariesContainsChange'], true),
eq(variables['monoContainsChange'], true),
eq(variables['isRollingBuild'], true))

Expand Down Expand Up @@ -2015,7 +2012,8 @@ extends:
eq(variables['isRollingBuild'], true))

#
# Build and test Mono Minijit with the libraries testss
# Build and test Mono Minijit with the libraries tests
# linux_arm64 runs on both library and mono changes
#
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
Expand All @@ -2025,6 +2023,33 @@ extends:
runtimeFlavor: mono
platforms:
- linux_arm64
jobParameters:
testGroup: innerloop
nameSuffix: Mono_MiniJIT_LibrariesTests
buildArgs: -s mono+libs+libs.tests -rc Release -c $(_BuildConfig) /p:ArchiveTests=true
timeoutInMinutes: 480
# extra steps, run tests
postBuildSteps:
- template: /eng/pipelines/libraries/helix.yml
parameters:
creator: dotnet-bot
testRunNamePrefixSuffix: Mono_Minijit_$(_BuildConfig)
condition: >-
or(
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true),
eq(variables['isRollingBuild'], true))

#
# Additional Mono Minijit platforms - only when mono explicitly changes
#
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/common/global-build-job.yml
helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml
buildConfig: ${{ variables.debugOnPrReleaseOnRolling }}
runtimeFlavor: mono
platforms:
- linux_x64
- osx_x64
#- windows_x64
Expand All @@ -2041,6 +2066,5 @@ extends:
testRunNamePrefixSuffix: Mono_Minijit_$(_BuildConfig)
condition: >-
or(
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true),
eq(variables['isRollingBuild'], true))
Loading