Skip to content

Remove duplicate instructions.#126147

Merged
vitek-karas merged 3 commits intodotnet:mainfrom
giritrivedi:remove_dublicates
Apr 27, 2026
Merged

Remove duplicate instructions.#126147
vitek-karas merged 3 commits intodotnet:mainfrom
giritrivedi:remove_dublicates

Conversation

@giritrivedi
Copy link
Copy Markdown
Contributor

  • Remove duplicate instructions.
  • Add missing comma

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Mar 26, 2026
@giritrivedi giritrivedi marked this pull request as ready for review March 26, 2026 10:35
@giritrivedi
Copy link
Copy Markdown
Contributor Author

Failures are unrelated due to the changes.

@giritrivedi
Copy link
Copy Markdown
Contributor Author

cc : @uweigand

@giritrivedi
Copy link
Copy Markdown
Contributor Author

Hello, can someone review and merge this PR ? .
Thanks

@giritrivedi
Copy link
Copy Markdown
Contributor Author

hi @steveisok , Is there anything needed from my end before this gets merged ?

@vitek-karas
Copy link
Copy Markdown
Member

I think somebody from the s390x community should at least comment on the validity of this change.

Comment thread src/mono/mono/arch/s390x/s390x-codegen.h
@vitek-karas
Copy link
Copy Markdown
Member

Thanks a lot @uweigand !

Just FYI: CI is broken due to infra problems, so unfortunately we will have to wait a bit (hopefully just a day or two)

Taking care of review comments.
Copy link
Copy Markdown
Contributor

@uweigand uweigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version LGTM, thanks!

@tannergooding
Copy link
Copy Markdown
Member

CI should be mostly sorted now and we should at least get a green Build Analysis run, allowing it to be merged without bypassing any checks.

@giritrivedi
Copy link
Copy Markdown
Contributor Author

Hello, Can this be merged if the CI is clean now. ?

@vitek-karas vitek-karas merged commit db9e39f into dotnet:main Apr 27, 2026
78 of 82 checks passed
@vitek-karas
Copy link
Copy Markdown
Member

Sorry for the delay - thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-s390x Related to s390x architecture (unsupported) area-VM-meta-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants