Skip to content

[Draft] Test CreateWhileGreaterThan/Equal in SVE2 #126236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhartglassMSFT wants to merge 8 commits into from
Closed

[Draft] Test CreateWhileGreaterThan/Equal in SVE2 #126236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f66878
initial impl without tests
dhartglassMSFT Mar 27, 2026
db3e3af
tests for createWhileGreater*
dhartglassMSFT Mar 28, 2026
6dfcbc2
combine the createWhile* cases together
dhartglassMSFT Mar 30, 2026
3faf84f
stash
dhartglassMSFT Apr 3, 2026
1bb92c6
testcase for RAW mask byte
dhartglassMSFT Apr 3, 2026
c516f90
have whileRWMaskTests use templates instead
dhartglassMSFT Apr 27, 2026
731643c
remove accidentally added files
dhartglassMSFT Apr 27, 2026
3f6d409
fix validator in test
dhartglassMSFT Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/coreclr/jit/hwintrinsic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2447,6 +2447,26 @@ GenTree* Compiler::impHWIntrinsic(NamedIntrinsic intrinsic,
case NI_Sve_CreateWhileLessThanOrEqualMaskUInt16:
case NI_Sve_CreateWhileLessThanOrEqualMaskUInt32:
case NI_Sve_CreateWhileLessThanOrEqualMaskUInt64:
case NI_Sve2_CreateWhileGreaterThanMaskByte:
case NI_Sve2_CreateWhileGreaterThanMaskDouble:
case NI_Sve2_CreateWhileGreaterThanMaskInt16:
case NI_Sve2_CreateWhileGreaterThanMaskInt32:
case NI_Sve2_CreateWhileGreaterThanMaskInt64:
case NI_Sve2_CreateWhileGreaterThanMaskSByte:
case NI_Sve2_CreateWhileGreaterThanMaskSingle:
case NI_Sve2_CreateWhileGreaterThanMaskUInt16:
case NI_Sve2_CreateWhileGreaterThanMaskUInt32:
case NI_Sve2_CreateWhileGreaterThanMaskUInt64:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskByte:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskDouble:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskInt16:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskInt32:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskInt64:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskSByte:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskSingle:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskUInt16:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskUInt32:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskUInt64:
retNode->AsHWIntrinsic()->SetAuxiliaryType(JitType2PreciseVarType(sigReader.op1JitType));
break;

Expand Down
87 changes: 65 additions & 22 deletions src/coreclr/jit/hwintrinsiccodegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,28 @@ void CodeGen::HWIntrinsicImmOpHelper::EmitCaseEnd()
}

//------------------------------------------------------------------------
//------------------------------------------------------------------------
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two consecutive separator lines (//------------------------------------------------------------------------) here. Consider keeping a single separator to match the surrounding style and reduce noise in diffs.

Suggested change
//------------------------------------------------------------------------

Copilot uses AI. Check for mistakes.
// Emit helper for SVE+SVE2 WHILE* intrinsics - these set the width
// (emitSize) based on the scalar operand
//
static void genEmitCreateWhileMask(emitter* emit,
GenTreeHWIntrinsic* node,
instruction ins,
instruction unsignedIns,
regNumber targetReg,
regNumber op1Reg,
regNumber op2Reg,
insOpts opt)
{
var_types auxType = node->GetAuxiliaryType();
emitAttr emitSize = emitActualTypeSize(auxType);
if (varTypeIsUnsigned(auxType))
{
ins = unsignedIns;
}
emit->emitIns_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, opt);
}

// genHWIntrinsic: Generates the code for a given hardware intrinsic node.
//
// Arguments:
Expand Down Expand Up @@ -2138,18 +2160,8 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
case NI_Sve_CreateWhileLessThanMaskUInt16:
case NI_Sve_CreateWhileLessThanMaskUInt32:
case NI_Sve_CreateWhileLessThanMaskUInt64:
{
// Emit size and instruction is based on the scalar operands.
var_types auxType = node->GetAuxiliaryType();
emitSize = emitActualTypeSize(auxType);
if (varTypeIsUnsigned(auxType))
{
ins = INS_sve_whilelo;
}

GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, opt);
genEmitCreateWhileMask(GetEmitter(), node, ins, INS_sve_whilelo, targetReg, op1Reg, op2Reg, opt);
break;
}

case NI_Sve_CreateWhileLessThanOrEqualMaskByte:
case NI_Sve_CreateWhileLessThanOrEqualMaskDouble:
Expand All @@ -2161,18 +2173,49 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
case NI_Sve_CreateWhileLessThanOrEqualMaskUInt16:
case NI_Sve_CreateWhileLessThanOrEqualMaskUInt32:
case NI_Sve_CreateWhileLessThanOrEqualMaskUInt64:
{
// Emit size and instruction is based on the scalar operands.
var_types auxType = node->GetAuxiliaryType();
emitSize = emitActualTypeSize(auxType);
if (varTypeIsUnsigned(auxType))
{
ins = INS_sve_whilels;
}

GetEmitter()->emitIns_R_R_R(ins, emitSize, targetReg, op1Reg, op2Reg, opt);
genEmitCreateWhileMask(GetEmitter(), node, ins, INS_sve_whilels, targetReg, op1Reg, op2Reg, opt);
break;

case NI_Sve2_CreateWhileGreaterThanMaskByte:
case NI_Sve2_CreateWhileGreaterThanMaskDouble:
case NI_Sve2_CreateWhileGreaterThanMaskInt16:
case NI_Sve2_CreateWhileGreaterThanMaskInt32:
case NI_Sve2_CreateWhileGreaterThanMaskInt64:
case NI_Sve2_CreateWhileGreaterThanMaskSByte:
case NI_Sve2_CreateWhileGreaterThanMaskSingle:
case NI_Sve2_CreateWhileGreaterThanMaskUInt16:
case NI_Sve2_CreateWhileGreaterThanMaskUInt32:
case NI_Sve2_CreateWhileGreaterThanMaskUInt64:
genEmitCreateWhileMask(GetEmitter(), node, ins, INS_sve_whilehi, targetReg, op1Reg, op2Reg, opt);
break;

case NI_Sve2_CreateWhileGreaterThanOrEqualMaskByte:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskDouble:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskInt16:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskInt32:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskInt64:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskSByte:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskSingle:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskUInt16:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskUInt32:
case NI_Sve2_CreateWhileGreaterThanOrEqualMaskUInt64:
genEmitCreateWhileMask(GetEmitter(), node, ins, INS_sve_whilehs, targetReg, op1Reg, op2Reg, opt);
break;

case NI_Sve2_CreateWhileReadAfterWriteMaskByte:
case NI_Sve2_CreateWhileReadAfterWriteMaskDouble:
case NI_Sve2_CreateWhileReadAfterWriteMaskInt16:
case NI_Sve2_CreateWhileReadAfterWriteMaskInt32:
case NI_Sve2_CreateWhileReadAfterWriteMaskInt64:
case NI_Sve2_CreateWhileReadAfterWriteMaskSByte:
case NI_Sve2_CreateWhileReadAfterWriteMaskSingle:
case NI_Sve2_CreateWhileReadAfterWriteMaskUInt16:
case NI_Sve2_CreateWhileReadAfterWriteMaskUInt32:
case NI_Sve2_CreateWhileReadAfterWriteMaskUInt64:
// WHILERW operands are always pointers (64-bit), so emitSize is always EA_8BYTE.
// No signed/unsigned instruction variant exists.
GetEmitter()->emitIns_R_R_R(ins, EA_8BYTE, targetReg, op1Reg, op2Reg, opt);
break;
}

case NI_Sve_GatherPrefetch8Bit:
case NI_Sve_GatherPrefetch16Bit:
Expand Down
Loading
Loading