fix import of SPN with Kerberos realm#126279
Merged
wfurt merged 7 commits intodotnet:mainfrom Apr 22, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds NegotiateAuthentication EnterpriseTests to exercise real Kerberos/Negotiate flows against a real KDC, expanding System.Net.Security’s enterprise-level coverage.
Changes:
- Include a new
NegotiateAuthenticationTest.csin the Enterprise test project. - Add several client-only and client/server NegotiateAuthentication handshake tests (including protection level and wrap/unwrap scenarios).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| src/libraries/System.Net.Security/tests/EnterpriseTests/System.Net.Security.Enterprise.Tests.csproj | Adds the new NegotiateAuthentication Enterprise test file to the test project. |
| src/libraries/System.Net.Security/tests/EnterpriseTests/NegotiateAuthenticationTest.cs | Introduces new enterprise tests for NegotiateAuthentication client/server scenarios against a KDC. |
This was referenced Mar 29, 2026
rzikm
approved these changes
Apr 7, 2026
|
This would be missing edge cases when you also have a realm. Eg HOST/linuxclient.domain.com@realm.io |
Member
Author
Anything beyond ClientAuthentication_TargetNameWithRealm_Succeeds @psmulovics |
|
@fhubi, does that cover all our use cases? |
wfurt
changed the title
Member
Author
|
Let me know @filipnavara if this makes sense to you. |
Probably yes. |
This was referenced Apr 22, 2026
Open
Open
Member
Author
|
/ba-g failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to Enterprise suite to run agains real KDC
fixes #126979