Follow-up to #126192: address review comments (doc nit, ShellExecuteHelper refactor, field keyword, test, trimming, waitStateHolder fix)#126314

Merged

adamsitnik merged 19 commits intomainfrom

copilot/follow-up-pr-126192-comments

Mar 31, 2026

Commits on Mar 30, 2026

Address review comments: fix "OS handle" doc nit, convert ShellExecuteHelper to private static methods

Copilot
and
adamsitnik
committed
Use field keyword for ProcessId; add test for invalid handle validation

Copilot
and
adamsitnik
committed
Pass SHELLEXECUTEINFO by value; return hProcess/hInstApp via out params

Copilot
and
adamsitnik
committed
Replace notPresent bool with ERROR_CALL_NOT_IMPLEMENTED in catch block

Copilot
and
jkotas
committed
Rename StartWithShellExecuteEx to StartWithShellExecute

Copilot
and
jkotas
committed
Fold ShellExecuteOnSTAThread into StartWithShellExecute; add static delegate for UseShellExecute trimming

Copilot
and
jkotas
committed
Move UseShellExecute property to shared ProcessStartInfo.cs

Copilot
and
adamsitnik
committed
Fold StartWithCreateProcess into StartCore on Windows

Copilot
and
jkotas
committed
Move s_startWithShellExecute to platform files, EnsureShellExecuteFunc to shared, GetShellError to local function

Copilot
and
jkotas
committed
Unix StartCore: move UseShellExecute delegate call after shared platform checks

Copilot
and
jkotas
committed
Make s_startWithShellExecute private in both platform files

Copilot
and
jkotas
committed

Commits on Mar 31, 2026