Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
]
},
"microsoft.dotnet.xharness.cli": {
"version": "8.0.0-prerelease.25516.2",
"version": "11.0.0-prerelease.26180.1",
"commands": [
"xharness"
]
Expand Down
12 changes: 6 additions & 6 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -322,17 +322,17 @@
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>edbd5c769a19798b6955050baccf99e6797d3208</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XHarness.TestRunners.Common" Version="8.0.0-prerelease.25516.2">
<Dependency Name="Microsoft.DotNet.XHarness.TestRunners.Common" Version="11.0.0-prerelease.26180.1">
<Uri>https://github.com/dotnet/xharness</Uri>
<Sha>402df9c4f5abe6ee8519181dfb5481e04099fab0</Sha>
<Sha>28f5ed3a089ff1a179f523da0c910348e9010414</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XHarness.TestRunners.Xunit" Version="8.0.0-prerelease.25516.2">
<Dependency Name="Microsoft.DotNet.XHarness.TestRunners.Xunit" Version="11.0.0-prerelease.26180.1">
<Uri>https://github.com/dotnet/xharness</Uri>
<Sha>402df9c4f5abe6ee8519181dfb5481e04099fab0</Sha>
<Sha>28f5ed3a089ff1a179f523da0c910348e9010414</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XHarness.CLI" Version="8.0.0-prerelease.25516.2">
<Dependency Name="Microsoft.DotNet.XHarness.CLI" Version="11.0.0-prerelease.26180.1">
<Uri>https://github.com/dotnet/xharness</Uri>
<Sha>402df9c4f5abe6ee8519181dfb5481e04099fab0</Sha>
<Sha>28f5ed3a089ff1a179f523da0c910348e9010414</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.PackageTesting" Version="8.0.0-beta.26112.1">
<Uri>https://github.com/dotnet/arcade</Uri>
Expand Down
6 changes: 3 additions & 3 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,9 @@
<!-- Testing -->
<MicrosoftNETCoreCoreDisToolsVersion>1.1.0</MicrosoftNETCoreCoreDisToolsVersion>
<MicrosoftNETTestSdkVersion>17.4.0-preview-20220707-01</MicrosoftNETTestSdkVersion>
<MicrosoftDotNetXHarnessTestRunnersCommonVersion>8.0.0-prerelease.25516.2</MicrosoftDotNetXHarnessTestRunnersCommonVersion>
<MicrosoftDotNetXHarnessTestRunnersXunitVersion>8.0.0-prerelease.25516.2</MicrosoftDotNetXHarnessTestRunnersXunitVersion>
<MicrosoftDotNetXHarnessCLIVersion>8.0.0-prerelease.25516.2</MicrosoftDotNetXHarnessCLIVersion>
<MicrosoftDotNetXHarnessTestRunnersCommonVersion>11.0.0-prerelease.26180.1</MicrosoftDotNetXHarnessTestRunnersCommonVersion>
<MicrosoftDotNetXHarnessTestRunnersXunitVersion>11.0.0-prerelease.26180.1</MicrosoftDotNetXHarnessTestRunnersXunitVersion>
<MicrosoftDotNetXHarnessCLIVersion>11.0.0-prerelease.26180.1</MicrosoftDotNetXHarnessCLIVersion>
<MicrosoftDotNetHotReloadUtilsGeneratorBuildToolVersion>8.0.0-alpha.0.26116.3</MicrosoftDotNetHotReloadUtilsGeneratorBuildToolVersion>
<XUnitVersion>2.4.2</XUnitVersion>
<XUnitAnalyzersVersion>1.0.0</XUnitAnalyzersVersion>
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/Common/tests/WasmTestRunner/WasmTestRunner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ public static async Task<int> Main(string[] args)
includedMethods.Add (args[i + 1]);
i++;
break;
case "-verbosity":
i++;
break;
default:
throw new ArgumentException($"Invalid argument '{option}'.");
}
Expand Down
4 changes: 4 additions & 0 deletions src/libraries/sendtohelixhelp.proj
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@

<PropertyGroup Condition="'$(TargetOS)' == 'browser' or '$(TargetOS)' == 'wasi' or '$(TargetOS)' == 'android' or '$(TargetOS)' == 'ios' or '$(TargetOS)' == 'iossimulator' or '$(TargetOS)' == 'tvos' or '$(TargetOS)' == 'tvossimulator' or '$(TargetOS)' == 'maccatalyst'">
<IncludeXHarnessCli>true</IncludeXHarnessCli>
<XHarnessTargetFramework>net8.0</XHarnessTargetFramework>
<UseDotNetCliVersionFromGlobalJson>true</UseDotNetCliVersionFromGlobalJson>
<!-- XHarness telemetry not supported with custom WASM workloads yet -->
<EnableXHarnessTelemetry Condition="'$(TargetOS)' == 'browser' or '$(TargetOS)' == 'wasi'">false</EnableXHarnessTelemetry>
</PropertyGroup>
Expand All @@ -91,6 +93,8 @@
<PropertyGroup Condition="'$(NeedsWorkload)' == 'true'">
<NeedsDotNetSdk>false</NeedsDotNetSdk>
<IncludeXHarnessCli>true</IncludeXHarnessCli>
<XHarnessTargetFramework>net8.0</XHarnessTargetFramework>
<UseDotNetCliVersionFromGlobalJson>true</UseDotNetCliVersionFromGlobalJson>
<EnableXHarnessTelemetry>true</EnableXHarnessTelemetry>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ protected string RunAndTestWasmApp(BuildArgs buildArgs,
useWasmConsoleOutput: useWasmConsoleOutput
);

TestUtils.AssertSubstring("AOT: image 'System.Private.CoreLib' found.", output, contains: buildArgs.AOT);
Comment thread
pavelsavara marked this conversation as resolved.
TestUtils.AssertSubstring($"AOT: image '{buildArgs.ProjectName}' found.", output, contains: buildArgs.AOT);

if (test != null)
Expand Down
11 changes: 10 additions & 1 deletion src/mono/wasm/Wasm.Build.Tests/data/test-main-7.0.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,15 @@ function processArguments(incomingArguments) {
}

runArgs.applicationArguments = incomingArguments;

// xharness appends its own control arguments here; keep them from reaching Main(string[] args).
for (let i = 0; i < runArgs.applicationArguments.length; i++) {
if (runArgs.applicationArguments[i] === "-verbosity") {
runArgs.applicationArguments.splice(i, 2);
i--;
}
}

// cheap way to let the testing infrastructure know we're running in a browser context (or not)
runArgs.environmentVariables["IsBrowserDomSupported"] = is_browser.toString().toLowerCase();
runArgs.environmentVariables["IsNodeJS"] = is_node.toString().toLowerCase();
Expand Down Expand Up @@ -352,4 +361,4 @@ async function run() {
}
}

run();
run();
9 changes: 9 additions & 0 deletions src/mono/wasm/runtime/loader/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,15 @@ export class HostBuilder implements DotnetHostBuilder {

const params = new URLSearchParams(window.location.search);
const values = params.getAll("arg");

// xharness appends its own control arguments here; keep them from reaching Main(string[] args).
for (let i = 0; i < values.length; i++) {
if (values[i] === "-verbosity") {
values.splice(i, 2);
i--;
}
}

return this.withApplicationArguments(...values);
} catch (err) {
mono_exit(1, err);
Expand Down
4 changes: 2 additions & 2 deletions src/mono/wasm/symbolicator/WasmSymbolicator.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

<ItemGroup>
<PackageReference Include="Microsoft.DotNet.XHarness.Common" Version="$(MicrosoftDotNetXHarnessTestRunnersCommonVersion)" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="6.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.1" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.1" />

<None Include="..\data\wasm-symbol-patterns.txt" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>
Expand Down
17 changes: 15 additions & 2 deletions src/mono/wasm/test-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,12 @@ async function getArgs() {
console.debug(`could not load /runArgs.json: ${response.status}. Ignoring`);
}
}
if (!runArgsJson)
runArgsJson = initRunArgs({});
if (!runArgsJson) {
// Older xharness/browser test paths on release/8.0 don't always emit
// runArgs.json. Keep the memory snapshot dry-run opt-in on that fallback
// path to avoid the relink/native hangs seen in CI.
runArgsJson = initRunArgs({ memorySnapshot: false });
}
return processArguments(queryArguments, runArgsJson);
}

Expand Down Expand Up @@ -164,6 +168,15 @@ function processArguments(incomingArguments, runArgs) {
}

runArgs.applicationArguments = incomingArguments;

// xharness appends its own control arguments here; keep them from reaching Main(string[] args).
for (let i = 0; i < runArgs.applicationArguments.length; i++) {
if (runArgs.applicationArguments[i] === "-verbosity") {
runArgs.applicationArguments.splice(i, 2);
i--;
}
}

// cheap way to let the testing infrastructure know we're running in a browser context (or not)
runArgs.environmentVariables["IsBrowserDomSupported"] = is_browser.toString().toLowerCase();
runArgs.environmentVariables["IsNodeJS"] = is_node.toString().toLowerCase();
Expand Down
7 changes: 4 additions & 3 deletions src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ public override Task Run(IEnumerable<TestAssemblyInfo> testAssemblies)
return Task.CompletedTask;
}

public override string WriteResultsToFile(XmlResultJargon xmlResultJargon)
public override Task<string> WriteResultsToFile(XmlResultJargon xmlResultJargon)
{
Debug.Assert(xmlResultJargon == XmlResultJargon.xUnit);
File.WriteAllText(ResultsFileName, LastTestRun.GetTestResultOutput(_assemblyName));
return ResultsFileName;
return Task.FromResult(ResultsFileName);
}

public override void WriteResultsToFile(TextWriter writer, XmlResultJargon jargon)
public override Task WriteResultsToFile(TextWriter writer, XmlResultJargon jargon)
{
Debug.Assert(jargon == XmlResultJargon.xUnit);
string lastTestResults = LastTestRun.GetTestResultOutput(_assemblyName);
Expand All @@ -69,6 +69,7 @@ public override void WriteResultsToFile(TextWriter writer, XmlResultJargon jargo
{
writer.WriteLine(lastTestResults);
}
return Task.CompletedTask;
}

public override void SkipTests(IEnumerable<string> tests)
Expand Down
1 change: 1 addition & 0 deletions src/tests/Common/helixpublishwitharcade.proj
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@

<PropertyGroup Condition="'$(TargetsMobile)' == 'true'">
<IncludeXHarnessCli>true</IncludeXHarnessCli>
<XHarnessTargetFramework>net8.0</XHarnessTargetFramework>
<EnableXHarnessTelemetry>true</EnableXHarnessTelemetry>
</PropertyGroup>

Expand Down
Loading